'Re: Review Request 115926: Refactor and centralize default-color generation into a central place'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 115926: Refactor and centralize default-color generation into a central place
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2014-02-20 22:19:43
Message-ID: 20140220221943.21075.93589 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115926/
-----------------------------------------------------------

(Updated Feb. 20, 2014, 10:19 p.m.)

Review request for Kate and Christoph Cullmann.

Changes
-------

better naming

Repository: kate

Description
-------

Instead of copy'n'pasting the generation of default colors, we put that into a
central place and generate the colors there.

Building on top of this patch, I plan to add some auto-tinting code as I use in
KDevelop for the currently hardcoded colors (see Qt::yellow & friends).

Please accept this for KDE4, as it's a bug fix for people like me.

Diffs (updated)
-----

  part/CMakeLists.txt 737f325 
  part/schema/kateschemaconfig.cpp 541be03 
  part/utils/kateconfig.cpp 65e8e8e 
  part/utils/katedefaultcolors.h PRE-CREATION 
  part/utils/katedefaultcolors.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115926/diff/

Testing
-------

Still looks as before to my eyes. Dunno if I regressed anything?

Thanks,

Milian Wolff

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115926/">https://git.reviewboard.kde.org/r/115926/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Milian Wolff.</div>

<p style="color: grey;"><i>Updated Feb. 20, 2014, 10:19 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">better naming</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Instead of copy&#39;n&#39;pasting the generation of default colors, we \
put that into a central place and generate the colors there.

Building on top of this patch, I plan to add some auto-tinting code as I use in
KDevelop for the currently hardcoded colors (see Qt::yellow &amp; friends).

Please accept this for KDE4, as it&#39;s a bug fix for people like me.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still looks as before to my eyes. Dunno if I regressed anything?</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>part/CMakeLists.txt <span style="color: grey">(737f325)</span></li>

 <li>part/schema/kateschemaconfig.cpp <span style="color: grey">(541be03)</span></li>

 <li>part/utils/kateconfig.cpp <span style="color: grey">(65e8e8e)</span></li>

 <li>part/utils/katedefaultcolors.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>part/utils/katedefaultcolors.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115926/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 