From kwrite-devel Thu Feb 20 22:19:43 2014 From: "Milian Wolff" Date: Thu, 20 Feb 2014 22:19:43 +0000 To: kwrite-devel Subject: Re: Review Request 115926: Refactor and centralize default-color generation into a central place Message-Id: <20140220221943.21075.93589 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=139293481401394 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0228277274297583565==" --===============0228277274297583565== Content-Type: multipart/alternative; boundary="===============7697625605947504983==" --===============7697625605947504983== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115926/ ----------------------------------------------------------- (Updated Feb. 20, 2014, 10:19 p.m.) Review request for Kate and Christoph Cullmann. Changes ------- better naming Repository: kate Description ------- Instead of copy'n'pasting the generation of default colors, we put that into a central place and generate the colors there. Building on top of this patch, I plan to add some auto-tinting code as I use in KDevelop for the currently hardcoded colors (see Qt::yellow & friends). Please accept this for KDE4, as it's a bug fix for people like me. Diffs (updated) ----- part/CMakeLists.txt 737f325 part/schema/kateschemaconfig.cpp 541be03 part/utils/kateconfig.cpp 65e8e8e part/utils/katedefaultcolors.h PRE-CREATION part/utils/katedefaultcolors.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115926/diff/ Testing ------- Still looks as before to my eyes. Dunno if I regressed anything? Thanks, Milian Wolff --===============7697625605947504983== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115926/

Review request for Kate and Christoph Cullmann.

By Milian Wolff.

Updated Feb. 20, 2014, 10:19 p.m.

Changes

better naming

Repository: kate

Description

Instead of copy'n'pasting the generation of default colors, we put that into a
central place and generate the colors there.

Building on top of this patch, I plan to add some auto-tinting code as I use in
KDevelop for the currently hardcoded colors (see Qt::yellow & friends).

Please accept this for KDE4, as it's a bug fix for people like me.

Testing

Still looks as before to my eyes. Dunno if I regressed anything?

Diffs (updated)

part/CMakeLists.txt (737f325)
part/schema/kateschemaconfig.cpp (541be03)
part/utils/kateconfig.cpp (65e8e8e)
part/utils/katedefaultcolors.h (PRE-CREATION)
part/utils/katedefaultcolors.cpp (PRE-CREATION)

View Diff

--===============7697625605947504983==-- --===============0228277274297583565== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============0228277274297583565==--