[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 115926: Refactor and centralize default-color generation into a central place
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2014-02-20 22:29:16
Message-ID: 20140220222916.26445.26834 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115926/#review50412
-----------------------------------------------------------
Looks almost good. Let's see what the holy belliness says to this.
part/utils/katecolors.h
<https://git.reviewboard.kde.org/r/115926/#comment35481>
we could start with 0, then you wouldn't need the "- 1" offset in \
KateSchemaConfigColorTab::colorItemList.
My suggestion:
enum Mark {
Bookmark = 0,
ActiveBreakpoint,
ReachedBreakpoint,
DisabledBreakpoint,
Execution,
Warning,
Error,
MarkCount
FIRST_MARK = Bookmark,
};
Then you can write as always:
for (i = 0, i < MarkCount; ++i)
part/utils/kateconfig.cpp
<https://git.reviewboard.kde.org/r/115926/#comment35482>
same here, I don't like =1 and the -1 in mark[] :-)
- Dominik Haumann
On Feb. 20, 2014, 10:19 p.m., Milian Wolff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115926/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 10:19 p.m.)
>
>
> Review request for Kate and Christoph Cullmann.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Instead of copy'n'pasting the generation of default colors, we put that into a
> central place and generate the colors there.
>
> Building on top of this patch, I plan to add some auto-tinting code as I use in
> KDevelop for the currently hardcoded colors (see Qt::yellow & friends).
>
> Please accept this for KDE4, as it's a bug fix for people like me.
>
>
> Diffs
> -----
>
> part/CMakeLists.txt 737f325
> part/schema/kateschemaconfig.cpp 541be03
> part/utils/kateconfig.cpp 65e8e8e
> part/utils/katedefaultcolors.h PRE-CREATION
> part/utils/katedefaultcolors.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115926/diff/
>
>
> Testing
> -------
>
> Still looks as before to my eyes. Dunno if I regressed anything?
>
>
> Thanks,
>
> Milian Wolff
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115926/">https://git.reviewboard.kde.org/r/115926/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks almost good. \
Let's see what the holy belliness says to this.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115926/diff/1/?file=245157#file245157line59" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/utils/katecolors.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">59</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Bookmark</span> <span class="o">=</span> <span class="mi">1</span><span \
class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we could \
start with 0, then you wouldn't need the "- 1" offset in \
KateSchemaConfigColorTab::colorItemList.
My suggestion:
enum Mark {
Bookmark = 0,
ActiveBreakpoint,
ReachedBreakpoint,
DisabledBreakpoint,
Execution,
Warning,
Error,
MarkCount
FIRST_MARK = Bookmark,
};
Then you can write as always:
for (i = 0, i < MarkCount; ++i)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115926/diff/1/?file=245159#file245159line2233" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/utils/kateconfig.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KateRendererConfig::setSchemaInternal( const QString &schema )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">2232</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">for</span> \
<span class="p">(</span><span class="kt">int</span> <span class="n">i</span> <span \
class="o">=</span> <span class="mi">1</span><span class="p">;</span> <span \
class="n">i</span> <span class="o"><=</span> <span \
class="n">KTextEditor</span><span class="o">::</span><span \
class="n">MarkInterface</span><span class="o">::</span><span \
class="n">reservedMarkersCount</span><span class="p">();</span> <span \
class="n">i</span><span class="o">++</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">2206</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">for</span> <span \
class="p">(</span><span class="kt">int</span> <span class="n">i</span> <span \
class="o">=</span> <span class="n">KateColors</span><span class="o">::</span><span \
class="n">FIRST_MARK</span><span class="p">;</span> <span class="n">i</span> <span \
class="o"><=</span> <span class="n">KateColors</span><span \
class="o">::</span><span class="n">LAST_MARK</span><span class="p">;</span> <span \
class="n">i</span><span class="o">++</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here, \
I don't like =1 and the -1 in mark[] :-)</pre> </div>
<br />
<p>- Dominik Haumann</p>
<br />
<p>On February 20th, 2014, 10:19 p.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 10:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Instead of copy'n'pasting the generation of default colors, we \
put that into a central place and generate the colors there.
Building on top of this patch, I plan to add some auto-tinting code as I use in
KDevelop for the currently hardcoded colors (see Qt::yellow & friends).
Please accept this for KDE4, as it's a bug fix for people like me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still looks as before to my eyes. Dunno if I regressed anything?</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/CMakeLists.txt <span style="color: grey">(737f325)</span></li>
<li>part/schema/kateschemaconfig.cpp <span style="color: grey">(541be03)</span></li>
<li>part/utils/kateconfig.cpp <span style="color: grey">(65e8e8e)</span></li>
<li>part/utils/katedefaultcolors.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>part/utils/katedefaultcolors.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115926/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic