--===============0228277274297583565== Content-Type: multipart/alternative; boundary="===============7697625605947504983==" --===============7697625605947504983== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115926/ ----------------------------------------------------------- (Updated Feb. 20, 2014, 10:19 p.m.) Review request for Kate and Christoph Cullmann. Changes ------- better naming Repository: kate Description ------- Instead of copy'n'pasting the generation of default colors, we put that into a central place and generate the colors there. Building on top of this patch, I plan to add some auto-tinting code as I use in KDevelop for the currently hardcoded colors (see Qt::yellow & friends). Please accept this for KDE4, as it's a bug fix for people like me. Diffs (updated) ----- part/CMakeLists.txt 737f325 part/schema/kateschemaconfig.cpp 541be03 part/utils/kateconfig.cpp 65e8e8e part/utils/katedefaultcolors.h PRE-CREATION part/utils/katedefaultcolors.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115926/diff/ Testing ------- Still looks as before to my eyes. Dunno if I regressed anything? Thanks, Milian Wolff --===============7697625605947504983== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115926/ |
Review request for Kate and Christoph Cullmann.
By Milian Wolff.
Updated Feb. 20, 2014, 10:19 p.m. Changes
Repository:
kate
Description
Testing
Diffs (updated)
|