[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114248: vi-mode: clear clearCurrentChangeLog after undo command
From: "Simon St James" <kdedevel () etotheipiplusone ! com>
Date: 2013-12-02 9:42:21
Message-ID: 20131202094221.10701.23053 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114248/#review44982
-----------------------------------------------------------
tests/vimode_test.cpp
<http://git.reviewboard.kde.org/r/114248/#comment32158>
For the ShouldFail comment, change to something like "Crash is fixed, but we need \
to correctly deal with the case where we enter Visual Mode due to Undo instead of v, \
etc"
- Simon St James
On Dec. 2, 2013, 9:36 a.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114248/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2013, 9:36 a.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 328277
> http://bugs.kde.org/show_bug.cgi?id=328277
>
>
> Repository: kate
>
>
> Description
> -------
>
> from my point of view the crash is much worse, then missing functionality (e.g. \
> correct repeat of indent after undo command). So, easy fix for now.
> Couldn't find a better place to put the clearCCL at.
>
>
> Diffs
> -----
>
> part/vimode/katevinormalmode.cpp 4e4d1d3
> tests/vimode_test.cpp 46da2f7
>
> Diff: http://git.reviewboard.kde.org/r/114248/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114248/">http://git.reviewboard.kde.org/r/114248/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114248/diff/2/?file=222053#file222053line763" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/vimode_test.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ViModeTest::VisualModeTests() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">763</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
DoTest("aaa\nbbb", "Vj>u>.", " aaa\n bbb", \
ShouldFail, "Should not crash");</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For the \
ShouldFail comment, change to something like "Crash is fixed, but we need to \
correctly deal with the case where we enter Visual Mode due to Undo instead of v, \
etc"</pre> </div>
<br />
<p>- Simon St James</p>
<br />
<p>On December 2nd, 2013, 9:36 a.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2013, 9:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=328277">328277</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">from my point of view the crash is much worse, then missing \
functionality (e.g. correct repeat of indent after undo command). So, easy fix for \
now.
Couldn't find a better place to put the clearCCL at.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/katevinormalmode.cpp <span style="color: grey">(4e4d1d3)</span></li>
<li>tests/vimode_test.cpp <span style="color: grey">(46da2f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114248/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic