'Re: Review Request 114248: vi-mode: clear clearCurrentChangeLog after undo command'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114248: vi-mode: clear clearCurrentChangeLog after undo command
From:       "Michal Humpula" <michal.humpula () seznam ! cz>
Date:       2013-12-02 9:36:55
Message-ID: 20131202093655.7075.28109 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114248/
-----------------------------------------------------------

(Updated Dec. 2, 2013, 9:36 a.m.)

Review request for Kate.

Changes
-------

added ShouldFail test.

Bugs: 328277
    http://bugs.kde.org/show_bug.cgi?id=328277

Repository: kate

Description
-------

from my point of view the crash is much worse, then missing functionality (e.g. \
correct repeat of indent after undo command). So, easy fix for now.

Couldn't find a better place to put the clearCCL at.

Diffs (updated)
-----

  part/vimode/katevinormalmode.cpp 4e4d1d3 
  tests/vimode_test.cpp 46da2f7 

Diff: http://git.reviewboard.kde.org/r/114248/diff/

Testing
-------

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114248/">http://git.reviewboard.kde.org/r/114248/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 2, 2013, 9:36 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">added ShouldFail test.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=328277">328277</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">from my point of view the crash is much worse, then missing \
functionality (e.g. correct repeat of indent after undo command). So, easy fix for \
now.

Couldn&#39;t find a better place to put the clearCCL at.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>part/vimode/katevinormalmode.cpp <span style="color: grey">(4e4d1d3)</span></li>

 <li>tests/vimode_test.cpp <span style="color: grey">(46da2f7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114248/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 