From kwrite-devel Mon Dec 02 09:42:21 2013 From: "Simon St James" Date: Mon, 02 Dec 2013 09:42:21 +0000 To: kwrite-devel Subject: Re: Review Request 114248: vi-mode: clear clearCurrentChangeLog after undo command Message-Id: <20131202094221.10701.23053 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=138597735509209 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4704248692734537058==" --===============4704248692734537058== Content-Type: multipart/alternative; boundary="===============8519140683801540050==" --===============8519140683801540050== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114248/#review44982 ----------------------------------------------------------- tests/vimode_test.cpp For the ShouldFail comment, change to something like "Crash is fixed, but we need to correctly deal with the case where we enter Visual Mode due to Undo instead of v, etc" - Simon St James On Dec. 2, 2013, 9:36 a.m., Michal Humpula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114248/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2013, 9:36 a.m.) > > > Review request for Kate. > > > Bugs: 328277 > http://bugs.kde.org/show_bug.cgi?id=328277 > > > Repository: kate > > > Description > ------- > > from my point of view the crash is much worse, then missing functionality (e.g. correct repeat of indent after undo command). So, easy fix for now. > > Couldn't find a better place to put the clearCCL at. > > > Diffs > ----- > > part/vimode/katevinormalmode.cpp 4e4d1d3 > tests/vimode_test.cpp 46da2f7 > > Diff: http://git.reviewboard.kde.org/r/114248/diff/ > > > Testing > ------- > > > Thanks, > > Michal Humpula > > --===============8519140683801540050== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114248/

tests/vimode_test.cpp (Diff revision 2) 
void ViModeTest::VisualModeTests() {
 

    763
    
   DoTest("aaa\nbbb", "Vj>u>.", "    aaa\n    bbb", ShouldFail, "Should not crash");

  


 





For the ShouldFail comment, change to something like "Crash is fixed, but we need to correctly deal with the case where we enter Visual Mode due to Undo instead of v, etc"









- Simon St James






On December 2nd, 2013, 9:36 a.m. UTC, Michal Humpula wrote:











 

  


Review request for Kate.


By Michal Humpula.




Updated Dec. 2, 2013, 9:36 a.m.










 Bugs: 


 328277









 Repository: 
kate





Description 

 

 

  
   
from my point of view the crash is much worse, then missing functionality (e.g. correct repeat of indent after undo command). So, easy fix for now.

Couldn't find a better place to put the clearCCL at.

  		
 







Diffs 


    

 
  • part/vimode/katevinormalmode.cpp (4e4d1d3)
    • 

 
  • tests/vimode_test.cpp (46da2f7)
    • 





View Diff








  		
 











  

 



--===============8519140683801540050==--

--===============4704248692734537058==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

--===============4704248692734537058==--