This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114248/

tests/vimode_test.cpp (Diff revision 2) 
void ViModeTest::VisualModeTests() {
 

    763
    
   DoTest("aaa\nbbb", "Vj>u>.", "    aaa\n    bbb", ShouldFail, "Should not crash");

  


 





For the ShouldFail comment, change to something like "Crash is fixed, but we need to correctly deal with the case where we enter Visual Mode due to Undo instead of v, etc"









- Simon St James






On December 2nd, 2013, 9:36 a.m. UTC, Michal Humpula wrote:











 

  


Review request for Kate.


By Michal Humpula.




Updated Dec. 2, 2013, 9:36 a.m.










 Bugs: 


 328277









 Repository: 
kate





Description 

 

 

  
   
from my point of view the crash is much worse, then missing functionality (e.g. correct repeat of indent after undo command). So, easy fix for now.

Couldn't find a better place to put the clearCCL at.

  		
 







Diffs 


    

 
  • part/vimode/katevinormalmode.cpp (4e4d1d3)
    • 

 
  • tests/vimode_test.cpp (46da2f7)
    • 





View Diff