'Re: Review Request: Start building up of ClientModel with the first Client to include'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Start building up of ClientModel with the first Client to include
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-26 18:10:27
Message-ID: 20120826181027.16360.60692 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106139/#review18042
-----------------------------------------------------------

This review has been submitted with commit 567f8cc50082ce5307aa7163fdf3176446a1df5a \
by Martin Gräßlin to branch KDE/4.9.

- Commit Hook

On Aug. 25, 2012, 11:32 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106139/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2012, 11:32 a.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Start building up of ClientModel with the first Client to include
> 
> So far the first Client to be shown in the list (that is the
> currently active window) was inserted as the last client into
> the list by prepending it to the list.
> 
> This meant that if another Client actually blocks the inclusion
> of the currently selected Client (e.g. only one window per app)
> the currently active Client never got included in this list.
> 
> This change ensures that the recently used model switching has
> the starting Client as the first Client in the list and also
> simplifies the code.
> 
> Stacking order switching mode is not adjusted as it seems rather
> broken, like the comment already says.
> 
> Patch requires review #106088
> 
> 
> This addresses bug 304950.
> http://bugs.kde.org/show_bug.cgi?id=304950
> 
> 
> Diffs
> -----
> 
> kwin/tabbox/tabbox.cpp 098d759 
> kwin/tabbox/clientmodel.cpp b78c1f5 
> 
> Diff: http://git.reviewboard.kde.org/r/106139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106139/">http://git.reviewboard.kde.org/r/106139/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 567f8cc50082ce5307aa7163fdf3176446a1df5a by Martin Gräßlin to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 25th, 2012, 11:32 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 25, 2012, 11:32 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Start building up of ClientModel with the first Client to include  
So far the first Client to be shown in the list (that is the
currently active window) was inserted as the last client into
the list by prepending it to the list.

This meant that if another Client actually blocks the inclusion
of the currently selected Client (e.g. only one window per app)
the currently active Client never got included in this list.

This change ensures that the recently used model switching has
the starting Client as the first Client in the list and also
simplifies the code.

Stacking order switching mode is not adjusted as it seems rather
broken, like the comment already says.

Patch requires review #106088</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=304950">304950</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tabbox/tabbox.cpp <span style="color: grey">(098d759)</span></li>

 <li>kwin/tabbox/clientmodel.cpp <span style="color: grey">(b78c1f5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106139/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 