'Re: Review Request: Use the first client as entrance to the focus chain if no active window'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use the first client as entrance to the focus chain if no active window
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-26 18:10:28
Message-ID: 20120826181028.16391.2625 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106088/#review18043
-----------------------------------------------------------

This review has been submitted with commit cc4fa37d22092e98b3d77fd1f3dd8ad752bb9879 \
by Martin Gräßlin to branch KDE/4.9.

- Commit Hook

On Aug. 25, 2012, 11:30 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106088/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2012, 11:30 a.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Use the first client as entrance to the focus chain if no active window
> 
> The recently used mode of TabBox uses the active window as the entrance
> into the focus chain. If there is no active window it does not find any
> Clients. To solve this issue the ClientModel now uses the first entry
> of the focus chain in case there is no active window.
> 
> BUG: 305449
> FIXED-IN: 4.9.1
> 
> 
> This addresses bug 305449.
> http://bugs.kde.org/show_bug.cgi?id=305449
> 
> 
> Diffs
> -----
> 
> kwin/tabbox/tests/test_tabbox_clientmodel.cpp cd2c963 
> kwin/tabbox/tests/test_tabbox_clientmodel.h 1bdf0d4 
> kwin/tabbox/tests/mock_tabboxhandler.cpp 1d27dc7 
> kwin/tabbox/tests/mock_tabboxhandler.h f13a820 
> kwin/tabbox/tabboxhandler.h 976f201 
> kwin/tabbox/clientmodel.cpp b78c1f5 
> kwin/tabbox/tabbox.h bf69ad9 
> kwin/tabbox/tabbox.cpp 098d759 
> 
> Diff: http://git.reviewboard.kde.org/r/106088/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106088/">http://git.reviewboard.kde.org/r/106088/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit cc4fa37d22092e98b3d77fd1f3dd8ad752bb9879 by Martin Gräßlin to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 25th, 2012, 11:30 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 25, 2012, 11:30 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use the first client as entrance to the focus chain if no active window

The recently used mode of TabBox uses the active window as the entrance
into the focus chain. If there is no active window it does not find any
Clients. To solve this issue the ClientModel now uses the first entry
of the focus chain in case there is no active window.

BUG: 305449
FIXED-IN: 4.9.1</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=305449">305449</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tabbox/tests/test_tabbox_clientmodel.cpp <span style="color: \
grey">(cd2c963)</span></li>

 <li>kwin/tabbox/tests/test_tabbox_clientmodel.h <span style="color: \
grey">(1bdf0d4)</span></li>

 <li>kwin/tabbox/tests/mock_tabboxhandler.cpp <span style="color: \
grey">(1d27dc7)</span></li>

 <li>kwin/tabbox/tests/mock_tabboxhandler.h <span style="color: \
grey">(f13a820)</span></li>

 <li>kwin/tabbox/tabboxhandler.h <span style="color: grey">(976f201)</span></li>

 <li>kwin/tabbox/clientmodel.cpp <span style="color: grey">(b78c1f5)</span></li>

 <li>kwin/tabbox/tabbox.h <span style="color: grey">(bf69ad9)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: grey">(098d759)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106088/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 