--===============4426940678227566380== Content-Type: multipart/alternative; boundary="===============1420388025868453093==" --===============1420388025868453093== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106139/#review18042 ----------------------------------------------------------- This review has been submitted with commit 567f8cc50082ce5307aa7163fdf31764= 46a1df5a by Martin Gr=C3=A4=C3=9Flin to branch KDE/4.9. - Commit Hook On Aug. 25, 2012, 11:32 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106139/ > ----------------------------------------------------------- > = > (Updated Aug. 25, 2012, 11:32 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > Start building up of ClientModel with the first Client to include > = > So far the first Client to be shown in the list (that is the > currently active window) was inserted as the last client into > the list by prepending it to the list. > = > This meant that if another Client actually blocks the inclusion > of the currently selected Client (e.g. only one window per app) > the currently active Client never got included in this list. > = > This change ensures that the recently used model switching has > the starting Client as the first Client in the list and also > simplifies the code. > = > Stacking order switching mode is not adjusted as it seems rather > broken, like the comment already says. > = > Patch requires review #106088 > = > = > This addresses bug 304950. > http://bugs.kde.org/show_bug.cgi?id=3D304950 > = > = > Diffs > ----- > = > kwin/tabbox/tabbox.cpp 098d759 = > kwin/tabbox/clientmodel.cpp b78c1f5 = > = > Diff: http://git.reviewboard.kde.org/r/106139/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============1420388025868453093== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106139/ 

This revie=
w has been submitted with commit 567f8cc50082ce5307aa7163fdf3176446a1df5a b=
y Martin Gr=C3=A4=C3=9Flin to branch KDE/4.9.

- Commit


On August 25th, 2012, 11:32 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated Aug. 25, 2012, 11:32 a.m.

Descripti= on 

Start building up of ClientModel with the first Client to in=
clude
    =

So far the first Client to be shown in the list (that is the
currently active window) was inserted as the last client into
the list by prepending it to the list.
    =

This meant that if another Client actually blocks the inclusion
of the currently selected Client (e.g. only one window per app)
the currently active Client never got included in this list.
    =

This change ensures that the recently used model switching has
the starting Client as the first Client in the list and also
simplifies the code.
    =

Stacking order switching mode is not adjusted as it seems rather
broken, like the comment already says.

Patch requires review #106088
Bugs: 304950

Diffs=

  • kwin/tabbox/tabbox.cpp (098d759)
  • kwin/tabbox/clientmodel.cpp (b78c1f5)

View Diff
--===============1420388025868453093==-- --===============4426940678227566380== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4426940678227566380==--