[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add appmenu support to kwin
From: Bellegarde_Cédric <gnumdk () gmail ! com>
Date: 2012-08-26 16:23:18
Message-ID: 20120826162318.5344.29122 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review18037
-----------------------------------------------------------
I've got another issue, when i call menu->popup(position) from kded module, menu \
doesn't get focus and doesn't close when clicking elsewhere...
Calling setWindowState(Qt::WindowActive) fix issue but only works one time...
void AppMenuModule::showVerticalMenu(QMenu* menu, QPoint p)
{
//FIXME seems to make popup get focus the first time it is shown
// Not working on second popup()
menu->setWindowState(Qt::WindowActive);
menu->popup(p);
if (m_waitingAction)
menu->setActiveAction(m_waitingAction);
connect(menu, SIGNAL(aboutToHide()), this, SLOT(slotAboutToHide()));
}
[15:56] <thiago> gnumdk: X11 has a major feature lack there
[15:56] <thiago> it's fixed on Wayland
[15:56] <thiago> until then, you need to cope with the issue and not try to acquire \
grabs if you can avoid it
But i don't know how to cope with the issue :( Any idea ?
- Bellegarde Cédric
On Aug. 23, 2012, 9:20 p.m., Bellegarde Cédric wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104344/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2012, 9:20 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Here a patch to add appmenu support to kwin via a menu button in titlebar
>
> Works by Lionel Chauvin and me, original review request: \
> https://git.reviewboard.kde.org/r/101162/
> It depends on:
> http://quickgit.kde.org/index.php?p=kded-appmenu.git
>
> It looks like this:
> https://www.youtube.com/watch?v=x1bm7Q6_SH4&hd=1
>
> New version, all drawing code moved to kded-appmenu as asked.
>
>
> Diffs
> -----
>
> kcontrol/style/finetuning.ui 2d384bc
> kcontrol/style/kcmstyle.h cd1472f
> kcontrol/style/kcmstyle.cpp 849a49b
> kwin/CMakeLists.txt ce69e84
> kwin/client.h f31707b
> kwin/client.cpp c541595
> kwin/clients/oxygen/oxygenbutton.h ea11717
> kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
> kwin/clients/oxygen/oxygenclient.h 98e60cc
> kwin/clients/oxygen/oxygenclient.cpp 5fbb4fb
> kwin/clients/oxygen/oxygenfactory.h b38b097
> kwin/clients/oxygen/oxygenfactory.cpp 5502a6a
> kwin/config-kwin.h.cmake e5ed2a6
> kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
> kwin/libkdecorations/kcommondecoration.h 3fe9fcf
> kwin/libkdecorations/kcommondecoration.cpp 13a4c49
> kwin/libkdecorations/kdecoration.h 614b902
> kwin/libkdecorations/kdecoration.cpp 71f4f8d
> kwin/workspace.h 16630f7
> kwin/workspace.cpp cf3f308
>
> Diff: http://git.reviewboard.kde.org/r/104344/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bellegarde Cédric
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104344/">http://git.reviewboard.kde.org/r/104344/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've got another \
issue, when i call menu->popup(position) from kded module, menu doesn't get \
focus and doesn't close when clicking elsewhere...
Calling setWindowState(Qt::WindowActive) fix issue but only works one time...
void AppMenuModule::showVerticalMenu(QMenu* menu, QPoint p)
{
//FIXME seems to make popup get focus the first time it is shown
// Not working on second popup()
menu->setWindowState(Qt::WindowActive);
menu->popup(p);
if (m_waitingAction)
menu->setActiveAction(m_waitingAction);
connect(menu, SIGNAL(aboutToHide()), this, SLOT(slotAboutToHide()));
}
[15:56] <thiago> gnumdk: X11 has a major feature lack there
[15:56] <thiago> it's fixed on Wayland
[15:56] <thiago> until then, you need to cope with the issue and not try to \
acquire grabs if you can avoid it
But i don't know how to cope with the issue :( Any idea ?
</pre>
<br />
<p>- Bellegarde</p>
<br />
<p>On August 23rd, 2012, 9:20 p.m., Bellegarde Cédric wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Bellegarde Cédric.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2012, 9:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Here a patch to add appmenu support to kwin via a menu button in \
titlebar
Works by Lionel Chauvin and me, original review request: \
https://git.reviewboard.kde.org/r/101162/
It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git
It looks like this:
https://www.youtube.com/watch?v=x1bm7Q6_SH4&hd=1
New version, all drawing code moved to kded-appmenu as asked.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/style/finetuning.ui <span style="color: grey">(2d384bc)</span></li>
<li>kcontrol/style/kcmstyle.h <span style="color: grey">(cd1472f)</span></li>
<li>kcontrol/style/kcmstyle.cpp <span style="color: grey">(849a49b)</span></li>
<li>kwin/CMakeLists.txt <span style="color: grey">(ce69e84)</span></li>
<li>kwin/client.h <span style="color: grey">(f31707b)</span></li>
<li>kwin/client.cpp <span style="color: grey">(c541595)</span></li>
<li>kwin/clients/oxygen/oxygenbutton.h <span style="color: \
grey">(ea11717)</span></li>
<li>kwin/clients/oxygen/oxygenbutton.cpp <span style="color: \
grey">(28aa8b1)</span></li>
<li>kwin/clients/oxygen/oxygenclient.h <span style="color: \
grey">(98e60cc)</span></li>
<li>kwin/clients/oxygen/oxygenclient.cpp <span style="color: \
grey">(5fbb4fb)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.h <span style="color: \
grey">(b38b097)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.cpp <span style="color: \
grey">(5502a6a)</span></li>
<li>kwin/config-kwin.h.cmake <span style="color: grey">(e5ed2a6)</span></li>
<li>kwin/kcmkwin/kwindecoration/buttons.cpp <span style="color: \
grey">(2d12244)</span></li>
<li>kwin/libkdecorations/kcommondecoration.h <span style="color: \
grey">(3fe9fcf)</span></li>
<li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: \
grey">(13a4c49)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(614b902)</span></li>
<li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(71f4f8d)</span></li>
<li>kwin/workspace.h <span style="color: grey">(16630f7)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(cf3f308)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104344/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic