[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Build option to remove the dependency on KWorkspace
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-02-28 8:17:27
Message-ID: 20120228081727.16500.2741 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104102/#review10977
-----------------------------------------------------------
trimalloc is some #ifdefs a lot of comments and 3 LOC
Given the raster system is default since 4.8 i'd just copy it.
--
Also kworkspace is a rather slim lib (216k) - if you really care i'd rather=
check *cough* some other lib (3.1M) mostly used to draw some pixmaps *coug=
h* and by it's deps making kwin capable to be a full blown web browser (24M=
) what by more enlightened people than myself has once been called a "kitch=
en sink" :-P
To put it straight: the dependency layout of libplasma is still a bad joke.
The theme renderer should get out there (QtSvg is onky 336k), because it's =
what most other applications may want to invoke - not the entire fat tail.
I'm not in the mood for a flamewar, though.
- Thomas L=C3=BCbking
On Feb. 28, 2012, 5:59 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104102/
> -----------------------------------------------------------
> =
> (Updated Feb. 28, 2012, 5:59 a.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> optionally remove dependenency on KWorkspace library.
> =
> =
> Diffs
> -----
> =
> kwin/CMakeLists.txt cba139b =
> kwin/config-kwin.h.cmake 8893fa4 =
> kwin/main.cpp d61db71 =
> =
> Diff: http://git.reviewboard.kde.org/r/104102/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104102/">http://git.reviewboard.kde.org/r/104102/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">trimalloc is some \
#ifdefs a lot of comments and 3 LOC Given the raster system is default since 4.8 \
i'd just copy it.
--
Also kworkspace is a rather slim lib (216k) - if you really care i'd rather check \
*cough* some other lib (3.1M) mostly used to draw some pixmaps *cough* and by \
it's deps making kwin capable to be a full blown web browser (24M) what by more \
enlightened people than myself has once been called a "kitchen sink" :-P
To put it straight: the dependency layout of libplasma is still a bad joke.
The theme renderer should get out there (QtSvg is onky 336k), because it's what \
most other applications may want to invoke - not the entire fat tail. I'm not in \
the mood for a flamewar, though.</pre> <br />
<p>- Thomas</p>
<br />
<p>On February 28th, 2012, 5:59 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2012, 5:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">optionally remove dependenency on KWorkspace library.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(cba139b)</span></li>
<li>kwin/config-kwin.h.cmake <span style="color: grey">(8893fa4)</span></li>
<li>kwin/main.cpp <span style="color: grey">(d61db71)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104102/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic