--===============4684143457820390933== Content-Type: multipart/alternative; boundary="===============6820059127360873215==" --===============6820059127360873215== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104102/#review10977 ----------------------------------------------------------- trimalloc is some #ifdefs a lot of comments and 3 LOC Given the raster system is default since 4.8 i'd just copy it. -- Also kworkspace is a rather slim lib (216k) - if you really care i'd rather= check *cough* some other lib (3.1M) mostly used to draw some pixmaps *coug= h* and by it's deps making kwin capable to be a full blown web browser (24M= ) what by more enlightened people than myself has once been called a "kitch= en sink" :-P To put it straight: the dependency layout of libplasma is still a bad joke. The theme renderer should get out there (QtSvg is onky 336k), because it's = what most other applications may want to invoke - not the entire fat tail. I'm not in the mood for a flamewar, though. - Thomas L=C3=BCbking On Feb. 28, 2012, 5:59 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104102/ > ----------------------------------------------------------- > = > (Updated Feb. 28, 2012, 5:59 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > optionally remove dependenency on KWorkspace library. > = > = > Diffs > ----- > = > kwin/CMakeLists.txt cba139b = > kwin/config-kwin.h.cmake 8893fa4 = > kwin/main.cpp d61db71 = > = > Diff: http://git.reviewboard.kde.org/r/104102/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============6820059127360873215== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104102/ 

trimalloc =
is some #ifdefs a lot of comments and 3 LOC
Given the raster system is default since 4.8 i'd just copy it.
--
Also kworkspace is a rather slim lib (216k) - if you really care i'd ra=
ther check *cough* some other lib (3.1M) mostly used to draw some pixmaps *=
cough* and by it's deps making kwin capable to be a full blown web brow=
ser (24M) what by more enlightened people than myself has once been called =
a "kitchen sink" :-P

To put it straight: the dependency layout of libplasma is still a bad joke.
The theme renderer should get out there (QtSvg is onky 336k), because it=
9;s what most other applications may want to invoke - not the entire fat ta=
il.
I'm not in the mood for a flamewar, though.

- Thomas


On February 28th, 2012, 5:59 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.
By Martin Gr=C3=A4=C3=9Flin.

Updated Feb. 28, 2012, 5:59 a.m.

Descripti= on 

optionally remove dependenency on KWorkspace library.

Diffs=

  • kwin/CMakeLists.txt (cba139b)
  • kwin/config-kwin.h.cmake (8893fa4)<= /li>
  • kwin/main.cpp (d61db71)

View Diff
--===============6820059127360873215==-- --===============4684143457820390933== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4684143457820390933==--