This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104102/

trimalloc is some #ifdefs a lot of comments and 3 LOC
Given the raster system is default since 4.8 i'd just copy it.
--
Also kworkspace is a rather slim lib (216k) - if you really care i'd rather check *cough* some other lib (3.1M) mostly used to draw some pixmaps *cough* and by it's deps making kwin capable to be a full blown web browser (24M) what by more enlightened people than myself has once been called a "kitchen sink" :-P

To put it straight: the dependency layout of libplasma is still a bad joke.
The theme renderer should get out there (QtSvg is onky 336k), because it's what most other applications may want to invoke - not the entire fat tail.
I'm not in the mood for a flamewar, though.

- Thomas


On February 28th, 2012, 5:59 a.m., Martin Gräßlin wrote:

Review request for kwin.
By Martin Gräßlin.

Updated Feb. 28, 2012, 5:59 a.m.

Description

optionally remove dependenency on KWorkspace library.

Diffs

  • kwin/CMakeLists.txt (cba139b)
  • kwin/config-kwin.h.cmake (8893fa4)
  • kwin/main.cpp (d61db71)

View Diff