[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Focus window under mouse after MouseLowerOp
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-02-21 9:39:02
Message-ID: 20120221093902.18755.82334 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 18, 2012, 2:20 p.m., Thomas Lübking wrote:
> > kwin/activation.cpp, line 459
> > <http://git.reviewboard.kde.org/r/103975/diff/2/?file=49567#file49567line459>
> >
> > this leads to crashes on logouts since get_window is NULL at a time, fixed for \
> > commit but am out of branch again and have not found a way to convince \
> > reviewboard to accept patches with "wrong" index. *shrug*
what might work with reviewboard is to use the "parent commit" feature, that is \
providing all the diffs leading to your patch so that the index matches. Or just \
start using git properly :-P
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103975/#review10716
-----------------------------------------------------------
On Feb. 16, 2012, 10:47 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103975/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2012, 10:47 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Added clientUnderMouse() -used as well by nextFocusPrefesrMouse- and pass the focus \
> there when lowered by mouseclick. No idea whether it should apply to toggle as well \
> (esp. not activating because of raising)
>
> This addresses bug 255052.
> http://bugs.kde.org/show_bug.cgi?id=255052
>
>
> Diffs
> -----
>
> kwin/activation.cpp 37f0070
> kwin/useractions.cpp b310a39
> kwin/workspace.h 092b6a7
>
> Diff: http://git.reviewboard.kde.org/r/103975/diff/
>
>
> Testing
> -------
>
> Yes - I hope nextFocusPrefersMouse remains working ;-)
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103975/">http://git.reviewboard.kde.org/r/103975/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 18th, 2012, 2:20 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103975/diff/2/?file=49567#file49567line459" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/activation.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
Workspace::activateNextClient(Client* c)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">440</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">while</span> <span class="p">(</span><span class="n">it</span> <span \
class="o">!=</span> <span class="n">stackingOrder</span><span \
class="p">().</span><span class="n">constBegin</span><span class="p">())</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">459</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">get_focus</span> <span class="o">==</span> <span \
class="n">c</span> <span class="o">||</span> <span class="n">get_focus</span><span \
class="o">-></span><span class="n">isDesktop</span><span class="p">())</span> \
<span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this leads to crashes on \
logouts since get_window is NULL at a time, fixed for commit but am out of branch \
again and have not found a way to convince reviewboard to accept patches with \
"wrong" index. *shrug*</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what might \
work with reviewboard is to use the "parent commit" feature, that is \
providing all the diffs leading to your patch so that the index matches. Or just \
start using git properly :-P</pre> <br />
<p>- Martin</p>
<br />
<p>On February 16th, 2012, 10:47 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2012, 10:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added clientUnderMouse() -used as well by nextFocusPrefesrMouse- and \
pass the focus there when lowered by mouseclick. No idea whether it should apply to \
toggle as well (esp. not activating because of raising)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes - I hope nextFocusPrefersMouse remains working ;-)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=255052">255052</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/activation.cpp <span style="color: grey">(37f0070)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(b310a39)</span></li>
<li>kwin/workspace.h <span style="color: grey">(092b6a7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103975/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic