'Re: Review Request: allow clients to withdraw their XShape mask'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: allow clients to withdraw their XShape mask
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-02-21 9:47:39
Message-ID: 20120221094739.19411.11836 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104007/#review10785
-----------------------------------------------------------

Ship it!

Ship It!

- Martin Gräßlin

On Feb. 17, 2012, 6:21 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104007/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2012, 6:21 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> See bug, clients can change but cannot withdraw custom masks (because the frameId() \
> mask isn't withdrawn) The decoration is just re-added when a custom mask is \
> withdrawn (and the window would usually have a deco) - we'd somehow have to trace \
> whether the user or the client has last touched the border setting and i don#t \
> think that's worth it. 
> 
> This addresses bug 293736.
> http://bugs.kde.org/show_bug.cgi?id=293736
> 
> 
> Diffs
> -----
> 
> kwin/client.cpp da0fd46 
> 
> Diff: http://git.reviewboard.kde.org/r/104007/diff/
> 
> 
> Testing
> -------
> 
> Bug exploit. Also ensured toggling the deco still works (yes, that's easily \
> broken), we don't start to decorate nonsense (detectNoBorder() is crucial...) and \
> the mask can be re-applied ( "else if (app_noborder)" ) 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104007/">http://git.reviewboard.kde.org/r/104007/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Martin</p>

<br />
<p>On February 17th, 2012, 6:21 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Feb. 17, 2012, 6:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">See bug, clients can change but cannot withdraw custom masks (because \
the frameId() mask isn&#39;t withdrawn) The decoration is just re-added when a custom \
mask is withdrawn (and the window would usually have a deco) - we&#39;d somehow have \
to trace whether the user or the client has last touched the border setting and i \
don#t think that&#39;s worth it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug exploit. Also ensured toggling the deco still works (yes, that&#39;s \
easily broken), we don&#39;t start to decorate nonsense (detectNoBorder() is \
crucial...) and the mask can be re-applied ( &quot;else if (app_noborder)&quot; \
)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=293736">293736</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.cpp <span style="color: grey">(da0fd46)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104007/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 