On February 18th, 2012, 2:20 p.m., Thomas Lübking wrote:

kwin/activation.cpp (Diff revision 2)
bool Workspace::activateNextClient(Client* c)
440	while (it != stackingOrder().constBegin()) {	459	if (get_focus == c || get_focus->isDesktop()) {

this leads to crashes on logouts since get_window is NULL at a time, fixed for commit but am out of branch again and have not found a way to convince reviewboard to accept patches with "wrong" index. *shrug*

what might work with reviewboard is to use the "parent commit" feature, that is providing all the diffs leading to your patch so that the index matches. Or just start using git properly :-P

- Martin

On February 16th, 2012, 10:47 p.m., Thomas Lübking wrote:

Added clientUnderMouse() -used as well by nextFocusPrefesrMouse- and pass the focus there when lowered by mouseclick.
No idea whether it should apply to toggle as well (esp. not activating because of raising)

Yes - I hope nextFocusPrefersMouse remains working ;-)