'Re: Review Request: Focus window under mouse after MouseLowerOp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Focus window under mouse after MouseLowerOp
From:       "Commit Hook" <null () kde ! org>
Date:       2012-02-21 17:14:54
Message-ID: 20120221171454.29093.71767 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103975/#review10798
-----------------------------------------------------------

This review has been submitted with commit c4e133e5008f73f46da9654011bcc71748a92aaf \
by Thomas Lübking to branch KDE/4.8.

- Commit Hook

On Feb. 16, 2012, 10:47 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103975/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2012, 10:47 p.m.)
> 
> 
> Review request for kwin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Added clientUnderMouse() -used as well by nextFocusPrefesrMouse- and pass the focus \
> there when lowered by mouseclick. No idea whether it should apply to toggle as well \
> (esp. not activating because of raising) 
> 
> This addresses bug 255052.
> http://bugs.kde.org/show_bug.cgi?id=255052
> 
> 
> Diffs
> -----
> 
> kwin/activation.cpp 37f0070 
> kwin/useractions.cpp b310a39 
> kwin/workspace.h 092b6a7 
> 
> Diff: http://git.reviewboard.kde.org/r/103975/diff/
> 
> 
> Testing
> -------
> 
> Yes - I hope nextFocusPrefersMouse remains working ;-)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103975/">http://git.reviewboard.kde.org/r/103975/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c4e133e5008f73f46da9654011bcc71748a92aaf by Thomas Lübking to \
branch KDE/4.8.</pre>  <br />

<p>- Commit</p>

<br />
<p>On February 16th, 2012, 10:47 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Feb. 16, 2012, 10:47 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added clientUnderMouse() -used as well by nextFocusPrefesrMouse- and \
pass the focus there when lowered by mouseclick. No idea whether it should apply to \
toggle as well (esp. not activating because of raising)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes - I hope nextFocusPrefersMouse remains working ;-)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=255052">255052</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/activation.cpp <span style="color: grey">(37f0070)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(b310a39)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(092b6a7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103975/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 