--===============5328675016113504512== Content-Type: multipart/alternative; boundary="===============8520347676570381433==" --===============8520347676570381433== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Feb. 18, 2012, 2:20 p.m., Thomas L=C3=BCbking wrote: > > kwin/activation.cpp, line 459 > > > > > > this leads to crashes on logouts since get_window is NULL at a time= , fixed for commit but am out of branch again and have not found a way to c= onvince reviewboard to accept patches with "wrong" index. *shrug* what might work with reviewboard is to use the "parent commit" feature, tha= t is providing all the diffs leading to your patch so that the index matche= s. Or just start using git properly :-P - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103975/#review10716 ----------------------------------------------------------- On Feb. 16, 2012, 10:47 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103975/ > ----------------------------------------------------------- > = > (Updated Feb. 16, 2012, 10:47 p.m.) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > Added clientUnderMouse() -used as well by nextFocusPrefesrMouse- and pass= the focus there when lowered by mouseclick. > No idea whether it should apply to toggle as well (esp. not activating be= cause of raising) > = > = > This addresses bug 255052. > http://bugs.kde.org/show_bug.cgi?id=3D255052 > = > = > Diffs > ----- > = > kwin/activation.cpp 37f0070 = > kwin/useractions.cpp b310a39 = > kwin/workspace.h 092b6a7 = > = > Diff: http://git.reviewboard.kde.org/r/103975/diff/ > = > = > Testing > ------- > = > Yes - I hope nextFocusPrefersMouse remains working ;-) > = > = > Thanks, > = > Thomas L=C3=BCbking > = > --===============8520347676570381433== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103975/

On February 18th, 2012, 2:20 p.m., Thomas L= =C3=BCbking wrote:

= = =
kwin/activation.cpp (Diff revision 2) 
bool Workspace::activateNextClient(Client* c)
440 
        while (it !=3D stackingOrder().constBegin()) =
{
 459 
        if (get_focus =3D=3D=
 c || get_focus->isDe=
sktop()) {
 
this lead=
s to crashes on logouts since get_window is NULL at a time, fixed for commi=
t but am out of branch again and have not found a way to convince reviewboa=
rd to accept patches with "wrong" index. *shrug*
what might work with reviewboard is to use the "parent commit&q=
uot; feature, that is providing all the diffs leading to your patch so that=
 the index matches. Or just start using git properly :-P

- Martin


On February 16th, 2012, 10:47 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated Feb. 16, 2012, 10:47 p.m.

Descripti= on 

Added clientUnderMouse() -used as well by nextFocusPrefesrMo=
use- and pass the focus there when lowered by mouseclick.
No idea whether it should apply to toggle as well (esp. not activating beca=
use of raising)

Testing <= /h1> 
Yes - I hope nextFocusPrefersMouse remains working ;-)
Bugs: 255052

Diffs=

  • kwin/activation.cpp (37f0070)
  • kwin/useractions.cpp (b310a39)
  • kwin/workspace.h (092b6a7)

View Diff
--===============8520347676570381433==-- --===============5328675016113504512== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============5328675016113504512==--