[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Move Workspace's compositing functionality to own class Compositor
From: "Arthur Arlt" <arre2000 () gmx ! de>
Date: 2012-01-23 9:37:49
Message-ID: 20120123093749.10022.98701 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 16, 2012, 12:49 p.m., Philipp Knechtges wrote:
> >
I am working on it. I already have merged it with the current master branch=
and it seems to work. Due to my exams in the next two weeks it will take a=
while inserting the proposals in this review request...
- Arthur
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102420/#review9860
-----------------------------------------------------------
On Aug. 24, 2011, 1:37 p.m., Arthur Arlt wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102420/
> -----------------------------------------------------------
> =
> (Updated Aug. 24, 2011, 1:37 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> This patch moves all the Workspace functionality implemented in file comp=
osite.cpp to its own class Compositor. A new header file composite.h was cr=
eated as well. All function calls were updated.
> Maybe the shortcut set to the slot 'slotToggleCompositing' in kwinbinding=
.cpp could be connected directly to the slot in class Compositor. At the mo=
ment it is redirected from Workspace.
> =
> =
> Diffs
> -----
> =
> kwin/activation.cpp 911e9e6 =
> kwin/bridge.cpp 06dde55 =
> kwin/client.cpp 9d86cc4 =
> kwin/composite.h PRE-CREATION =
> kwin/composite.cpp 2b8ea6f =
> kwin/effects.cpp bbf5a45 =
> kwin/events.cpp dd2c3a4 =
> kwin/geometry.cpp b518ae8 =
> kwin/layers.cpp 3ce9903 =
> kwin/toplevel.cpp 8ec1b82 =
> kwin/workspace.h 2cba848 =
> kwin/workspace.cpp 9aa259c =
> =
> Diff: http://git.reviewboard.kde.org/r/102420/diff/diff
> =
> =
> Testing
> -------
> =
> Compiles and runs so far. Compositing works. However, I did not test it v=
ery intensively. Please report any inconsistencies. Thx.
> =
> =
> Thanks,
> =
> Arthur Arlt
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102420/">http://git.reviewboard.kde.org/r/102420/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am working on it. I \
already have merged it with the current master branch and it seems to work. Due to my \
exams in the next two weeks it will take a while inserting the proposals in this \
review request...</pre> <br />
<p>- Arthur</p>
<br />
<p>On August 24th, 2011, 1:37 p.m., Arthur Arlt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Arthur Arlt.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2011, 1:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch moves all the Workspace functionality implemented in file \
composite.cpp to its own class Compositor. A new header file composite.h was created \
as well. All function calls were updated. Maybe the shortcut set to the slot \
'slotToggleCompositing' in kwinbinding.cpp could be connected directly to the \
slot in class Compositor. At the moment it is redirected from Workspace.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and runs so far. Compositing works. However, I did not test it \
very intensively. Please report any inconsistencies. Thx.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/activation.cpp <span style="color: grey">(911e9e6)</span></li>
<li>kwin/bridge.cpp <span style="color: grey">(06dde55)</span></li>
<li>kwin/client.cpp <span style="color: grey">(9d86cc4)</span></li>
<li>kwin/composite.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(2b8ea6f)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(bbf5a45)</span></li>
<li>kwin/events.cpp <span style="color: grey">(dd2c3a4)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(b518ae8)</span></li>
<li>kwin/layers.cpp <span style="color: grey">(3ce9903)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(8ec1b82)</span></li>
<li>kwin/workspace.h <span style="color: grey">(2cba848)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(9aa259c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102420/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic