From kwin Mon Jan 23 09:37:49 2012 From: "Arthur Arlt" Date: Mon, 23 Jan 2012 09:37:49 +0000 To: kwin Subject: Re: Review Request: Move Workspace's compositing functionality to own class Compositor Message-Id: <20120123093749.10022.98701 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=132731165404470 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2876315019655980027==" --===============2876315019655980027== Content-Type: multipart/alternative; boundary="===============8351640481305789648==" --===============8351640481305789648== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Jan. 16, 2012, 12:49 p.m., Philipp Knechtges wrote: > > I am working on it. I already have merged it with the current master branch= and it seems to work. Due to my exams in the next two weeks it will take a= while inserting the proposals in this review request... - Arthur ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102420/#review9860 ----------------------------------------------------------- On Aug. 24, 2011, 1:37 p.m., Arthur Arlt wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102420/ > ----------------------------------------------------------- > = > (Updated Aug. 24, 2011, 1:37 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > This patch moves all the Workspace functionality implemented in file comp= osite.cpp to its own class Compositor. A new header file composite.h was cr= eated as well. All function calls were updated. > Maybe the shortcut set to the slot 'slotToggleCompositing' in kwinbinding= .cpp could be connected directly to the slot in class Compositor. At the mo= ment it is redirected from Workspace. > = > = > Diffs > ----- > = > kwin/activation.cpp 911e9e6 = > kwin/bridge.cpp 06dde55 = > kwin/client.cpp 9d86cc4 = > kwin/composite.h PRE-CREATION = > kwin/composite.cpp 2b8ea6f = > kwin/effects.cpp bbf5a45 = > kwin/events.cpp dd2c3a4 = > kwin/geometry.cpp b518ae8 = > kwin/layers.cpp 3ce9903 = > kwin/toplevel.cpp 8ec1b82 = > kwin/workspace.h 2cba848 = > kwin/workspace.cpp 9aa259c = > = > Diff: http://git.reviewboard.kde.org/r/102420/diff/diff > = > = > Testing > ------- > = > Compiles and runs so far. Compositing works. However, I did not test it v= ery intensively. Please report any inconsistencies. Thx. > = > = > Thanks, > = > Arthur Arlt > = > --===============8351640481305789648== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102420/ 

I am workin=
g on it. I already have merged it with the current master branch and it see=
ms to work. Due to my exams in the next two weeks it will take a while inse=
rting the proposals in this review request...

- Arthur


On August 24th, 2011, 1:37 p.m., Arthur Arlt wrote:

Review request for kwin.
By Arthur Arlt.

Updated Aug. 24, 2011, 1:37 p.m.

Descripti= on 

This patch moves all the Workspace functionality implemented=
 in file composite.cpp to its own class Compositor. A new header file compo=
site.h was created as well. All function calls were updated.
Maybe the shortcut set to the slot 'slotToggleCompositing' in kwinb=
inding.cpp could be connected directly to the slot in class Compositor. At =
the moment it is redirected from Workspace.

Testing <= /h1> 
Compiles and runs so far. Compositing works. However, I did =
not test it very intensively. Please report any inconsistencies. Thx.

Diffs=

  • kwin/activation.cpp (911e9e6)
  • kwin/bridge.cpp (06dde55)
  • kwin/client.cpp (9d86cc4)
  • kwin/composite.h (PRE-CREATION)
  • kwin/composite.cpp (2b8ea6f)
  • kwin/effects.cpp (bbf5a45)
  • kwin/events.cpp (dd2c3a4)
  • kwin/geometry.cpp (b518ae8)
  • kwin/layers.cpp (3ce9903)
  • kwin/toplevel.cpp (8ec1b82)
  • kwin/workspace.h (2cba848)
  • kwin/workspace.cpp (9aa259c)

View Diff
--===============8351640481305789648==-- --===============2876315019655980027== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2876315019655980027==--