[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Move Workspace's compositing functionality to own class Compositor
From: "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date: 2012-01-16 12:49:02
Message-ID: 20120116124902.27621.86050 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102420/#review9860
-----------------------------------------------------------
kwin/workspace.h
<http://git.reviewboard.kde.org/r/102420/#comment8189>
Just a small typo.
kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/102420/#comment8188>
same typo :)
- Philipp Knechtges
On Aug. 24, 2011, 1:37 p.m., Arthur Arlt wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102420/
> -----------------------------------------------------------
> =
> (Updated Aug. 24, 2011, 1:37 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> This patch moves all the Workspace functionality implemented in file comp=
osite.cpp to its own class Compositor. A new header file composite.h was cr=
eated as well. All function calls were updated.
> Maybe the shortcut set to the slot 'slotToggleCompositing' in kwinbinding=
.cpp could be connected directly to the slot in class Compositor. At the mo=
ment it is redirected from Workspace.
> =
> =
> Diffs
> -----
> =
> kwin/activation.cpp 911e9e6 =
> kwin/bridge.cpp 06dde55 =
> kwin/client.cpp 9d86cc4 =
> kwin/composite.h PRE-CREATION =
> kwin/composite.cpp 2b8ea6f =
> kwin/effects.cpp bbf5a45 =
> kwin/events.cpp dd2c3a4 =
> kwin/geometry.cpp b518ae8 =
> kwin/layers.cpp 3ce9903 =
> kwin/toplevel.cpp 8ec1b82 =
> kwin/workspace.h 2cba848 =
> kwin/workspace.cpp 9aa259c =
> =
> Diff: http://git.reviewboard.kde.org/r/102420/diff/diff
> =
> =
> Testing
> -------
> =
> Compiles and runs so far. Compositing works. However, I did not test it v=
ery intensively. Please report any inconsistencies. Thx.
> =
> =
> Thanks,
> =
> Arthur Arlt
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102420/">http://git.reviewboard.kde.org/r/102420/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102420/diff/2/?file=32767#file32767line628" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/workspace.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public \
slots:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">609</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n"><span class="hl">rese</span>tCom<span \
class="hl">p</span>ositing</span><span class="p"><span \
class="hl">(</span>);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">612</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span \
class="n"><span class="hl">slo</span>tComositing<span \
class="hl">Toggled</span></span><span class="p"><span class="hl">(</span></span><span \
class="n"><span class="hl">bool</span></span><span class="hl"> </span><span \
class="n"><span class="hl">active</span></span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just a \
small typo.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102420/diff/2/?file=32768#file32768line2234" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/workspace.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void Workspace::toggleCompositing()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2204</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">Workspace</span><span class="o">::</span><span \
class="n">slotComositingToggled</span><span class="p">(</span><span \
class="kt">bool</span> <span class="n">active</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same typo \
:)</pre> </div>
<br />
<p>- Philipp</p>
<br />
<p>On August 24th, 2011, 1:37 p.m., Arthur Arlt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Arthur Arlt.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2011, 1:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch moves all the Workspace functionality implemented in file \
composite.cpp to its own class Compositor. A new header file composite.h was created \
as well. All function calls were updated. Maybe the shortcut set to the slot \
'slotToggleCompositing' in kwinbinding.cpp could be connected directly to the \
slot in class Compositor. At the moment it is redirected from Workspace.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and runs so far. Compositing works. However, I did not test it \
very intensively. Please report any inconsistencies. Thx.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/activation.cpp <span style="color: grey">(911e9e6)</span></li>
<li>kwin/bridge.cpp <span style="color: grey">(06dde55)</span></li>
<li>kwin/client.cpp <span style="color: grey">(9d86cc4)</span></li>
<li>kwin/composite.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/composite.cpp <span style="color: grey">(2b8ea6f)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(bbf5a45)</span></li>
<li>kwin/events.cpp <span style="color: grey">(dd2c3a4)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(b518ae8)</span></li>
<li>kwin/layers.cpp <span style="color: grey">(3ce9903)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(8ec1b82)</span></li>
<li>kwin/workspace.h <span style="color: grey">(2cba848)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(9aa259c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102420/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic