'Re: Review Request: Move Workspace's compositing functionality to own class Compositor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Move Workspace's compositing functionality to own class Compositor
From:       "Arthur Arlt" <arre2000 () gmx ! de>
Date:       2012-05-02 16:19:29
Message-ID: 20120502161929.7445.23418 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102420/
-----------------------------------------------------------

(Updated May 2, 2012, 4:19 p.m.)

Review request for kwin.

Changes
-------

Rebase on recent master. Seems to crash at KDE startup, but works after aut=
o restart.

Description
-------

This patch moves all the Workspace functionality implemented in file compos=
ite.cpp to its own class Compositor. A new header file composite.h was crea=
ted as well. All function calls were updated.
Maybe the shortcut set to the slot 'slotToggleCompositing' in kwinbinding.c=
pp could be connected directly to the slot in class Compositor. At the mome=
nt it is redirected from Workspace.

Diffs (updated)
-----

  kwin/composite.h PRE-CREATION =

  kwin/client.cpp 410ff43 =

  kwin/activation.cpp 451394f =

  kwin/bridge.cpp 897d432 =

  kwin/composite.cpp 6a27e00 =

  kwin/effects.cpp 8e73780 =

  kwin/events.cpp cb397b2 =

  kwin/geometry.cpp 92a23e3 =

  kwin/layers.cpp ed8555c =

  kwin/toplevel.cpp 00bd7dd =

  kwin/workspace.h 9df435c =

  kwin/workspace.cpp b5c8014 =

Diff: http://git.reviewboard.kde.org/r/102420/diff/

Testing
-------

Compiles and runs so far. Compositing works. However, I did not test it ver=
y intensively. Please report any inconsistencies. Thx.

Thanks,

Arthur Arlt

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102420/">http://git.reviewboard.kde.org/r/102420/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Arthur Arlt.</div>

<p style="color: grey;"><i>Updated May 2, 2012, 4:19 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rebase on recent master. Seems to crash at KDE startup, but works after \
auto restart.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch moves all the Workspace functionality implemented in file \
composite.cpp to its own class Compositor. A new header file composite.h was created \
as well. All function calls were updated. Maybe the shortcut set to the slot \
&#39;slotToggleCompositing&#39; in kwinbinding.cpp could be connected directly to the \
slot in class Compositor. At the moment it is redirected from Workspace.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and runs so far. Compositing works. However, I did not test it \
very intensively. Please report any inconsistencies. Thx.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(410ff43)</span></li>

 <li>kwin/activation.cpp <span style="color: grey">(451394f)</span></li>

 <li>kwin/bridge.cpp <span style="color: grey">(897d432)</span></li>

 <li>kwin/composite.cpp <span style="color: grey">(6a27e00)</span></li>

 <li>kwin/effects.cpp <span style="color: grey">(8e73780)</span></li>

 <li>kwin/events.cpp <span style="color: grey">(cb397b2)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(92a23e3)</span></li>

 <li>kwin/layers.cpp <span style="color: grey">(ed8555c)</span></li>

 <li>kwin/toplevel.cpp <span style="color: grey">(00bd7dd)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(9df435c)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(b5c8014)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102420/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 