This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102420/

I am working on it. I already have merged it with the current master branch and it seems to work. Due to my exams in the next two weeks it will take a while inserting the proposals in this review request...

- Arthur


On August 24th, 2011, 1:37 p.m., Arthur Arlt wrote:

Review request for kwin.
By Arthur Arlt.

Updated Aug. 24, 2011, 1:37 p.m.

Description

This patch moves all the Workspace functionality implemented in file composite.cpp to its own class Compositor. A new header file composite.h was created as well. All function calls were updated.
Maybe the shortcut set to the slot 'slotToggleCompositing' in kwinbinding.cpp could be connected directly to the slot in class Compositor. At the moment it is redirected from Workspace.

Testing

Compiles and runs so far. Compositing works. However, I did not test it very intensively. Please report any inconsistencies. Thx.

Diffs

  • kwin/activation.cpp (911e9e6)
  • kwin/bridge.cpp (06dde55)
  • kwin/client.cpp (9d86cc4)
  • kwin/composite.h (PRE-CREATION)
  • kwin/composite.cpp (2b8ea6f)
  • kwin/effects.cpp (bbf5a45)
  • kwin/events.cpp (dd2c3a4)
  • kwin/geometry.cpp (b518ae8)
  • kwin/layers.cpp (3ce9903)
  • kwin/toplevel.cpp (8ec1b82)
  • kwin/workspace.h (2cba848)
  • kwin/workspace.cpp (9aa259c)

View Diff