[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix an annoying CMake warning in the msword-odf filter
From: "Thomas Zander" <zander () kde ! org>
Date: 2012-03-08 19:59:45
Message-ID: 20120308195945.22435.63965 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104192/#review11246
-----------------------------------------------------------
Ship it!
Ship It!
- Thomas Zander
On March 8, 2012, 12:28 p.m., Robert Mathias Marmorstein wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104192/
> -----------------------------------------------------------
> =
> (Updated March 8, 2012, 12:28 p.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Description
> -------
> =
> CMake 2.8 changed the default behavior of the module finding algorithm so=
that it looks in local paths before it looks in system paths. This makes =
a lot of sense and there's no reason not to accept the new behavior. Unfor=
tunately, CMake generates an annoying warning if you don't add a cmake_poli=
cy line to your CMakeLists.txt file approving this change. This patch supp=
resses that warning by accepting the new behavior for that filter.
> =
> =
> Diffs
> -----
> =
> filters/kword/msword-odf/wv2/CMakeLists.txt 2fc0d70 =
> =
> Diff: http://git.reviewboard.kde.org/r/104192/diff/
> =
> =
> Testing
> -------
> =
> Reran cmake and built everything both with gcc and clang. Everything bui=
lds fine and both kword and artwork still run just fine.
> =
> =
> Thanks,
> =
> Robert Mathias Marmorstein
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104192/">http://git.reviewboard.kde.org/r/104192/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 8th, 2012, 12:28 p.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style="color: grey;"><i>Updated March 8, 2012, 12:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">CMake 2.8 changed the default behavior of the module finding algorithm \
so that it looks in local paths before it looks in system paths. This makes a lot of \
sense and there's no reason not to accept the new behavior. Unfortunately, CMake \
generates an annoying warning if you don't add a cmake_policy line to your \
CMakeLists.txt file approving this change. This patch suppresses that warning by \
accepting the new behavior for that filter.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Reran cmake and built everything both with gcc and clang. Everything \
builds fine and both kword and artwork still run just fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/kword/msword-odf/wv2/CMakeLists.txt <span style="color: \
grey">(2fc0d70)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104192/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic