This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104192/

Ship it!

Ship It!

- Thomas


On March 8th, 2012, 12:28 p.m., Robert Mathias Marmorstein wrote:

Review request for KOffice.
By Robert Mathias Marmorstein.

Updated March 8, 2012, 12:28 p.m.

Description

CMake 2.8 changed the default behavior of the module finding algorithm so that it looks in local paths before it looks in system paths.  This makes a lot of sense and there's no reason not to accept the new behavior.  Unfortunately, CMake generates an annoying warning if you don't add a cmake_policy line to your CMakeLists.txt file approving this change.  This patch suppresses that warning by accepting the new behavior for that filter.

Testing

Reran cmake and built everything both with gcc and clang.  Everything builds fine and both kword and artwork still run just fine.

Diffs

  • filters/kword/msword-odf/wv2/CMakeLists.txt (2fc0d70)

View Diff