'Review Request: Fix an annoying CMake warning in the msword-odf filter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Fix an annoying CMake warning in the msword-odf filter
From:       "Robert Mathias Marmorstein" <robert () narnia ! homeunix ! com>
Date:       2012-03-08 12:28:23
Message-ID: 20120308122823.19404.20128 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104192/
-----------------------------------------------------------

Review request for KOffice.

Description
-------

CMake 2.8 changed the default behavior of the module finding algorithm so t=
hat it looks in local paths before it looks in system paths.  This makes a =
lot of sense and there's no reason not to accept the new behavior.  Unfortu=
nately, CMake generates an annoying warning if you don't add a cmake_policy=
 line to your CMakeLists.txt file approving this change.  This patch suppre=
sses that warning by accepting the new behavior for that filter.

Diffs
-----

  filters/kword/msword-odf/wv2/CMakeLists.txt 2fc0d70 =

Diff: http://git.reviewboard.kde.org/r/104192/diff/

Testing
-------

Reran cmake and built everything both with gcc and clang.  Everything build=
s fine and both kword and artwork still run just fine.

Thanks,

Robert Mathias Marmorstein

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104192/">http://git.reviewboard.kde.org/r/104192/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">CMake 2.8 changed the default behavior of the module finding algorithm \
so that it looks in local paths before it looks in system paths.  This makes a lot of \
sense and there&#39;s no reason not to accept the new behavior.  Unfortunately, CMake \
generates an annoying warning if you don&#39;t add a cmake_policy line to your \
CMakeLists.txt file approving this change.  This patch suppresses that warning by \
accepting the new behavior for that filter.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Reran cmake and built everything both with gcc and clang.  Everything \
builds fine and both kword and artwork still run just fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>filters/kword/msword-odf/wv2/CMakeLists.txt <span style="color: \
grey">(2fc0d70)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104192/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 