[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix confusing CMake messages
From: "Thomas Zander" <zander () kde ! org>
Date: 2012-03-08 19:42:09
Message-ID: 20120308194209.21809.71127 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104191/#review11244
-----------------------------------------------------------
Ship it!
Ship It!
- Thomas Zander
On March 8, 2012, 5:29 a.m., Robert Mathias Marmorstein wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104191/
> -----------------------------------------------------------
> =
> (Updated March 8, 2012, 5:29 a.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Description
> -------
> =
> This fixes a problem with how CMake reports a missing libwps. I think th=
is is a bug I introduced myself when upgrading things to the new wpg librar=
ies. Essentially, instead of reporting that libwps was missing, it was rep=
orting that the libwpg stream library was missing. While it's true that li=
bwps IS the libwpg stream library, most distributions package it as libwps.=
=
> =
> Additionally, the cmake module was not correctly checking the cache to se=
e whether libwps had been installed. So if someone ran cmake, got the erro=
r, and then installed wps, the error would come up even if the problem had =
been corrected. =
> =
> This patch fixes both glitches.
> =
> =
> Diffs
> -----
> =
> cmake/modules/FindWPG.cmake cb12f91 =
> filters/artwork/CMakeLists.txt b949dd9 =
> =
> Diff: http://git.reviewboard.kde.org/r/104191/diff/
> =
> =
> Testing
> -------
> =
> KOffice builds and runs both with and without libwps and CMake correctly =
detects whether libwps is present.
> =
> =
> Thanks,
> =
> Robert Mathias Marmorstein
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104191/">http://git.reviewboard.kde.org/r/104191/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 8th, 2012, 5:29 a.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style="color: grey;"><i>Updated March 8, 2012, 5:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes a problem with how CMake reports a missing libwps. I think \
this is a bug I introduced myself when upgrading things to the new wpg libraries. \
Essentially, instead of reporting that libwps was missing, it was reporting that the \
libwpg stream library was missing. While it's true that libwps IS the libwpg \
stream library, most distributions package it as libwps.
Additionally, the cmake module was not correctly checking the cache to see whether \
libwps had been installed. So if someone ran cmake, got the error, and then \
installed wps, the error would come up even if the problem had been corrected.
This patch fixes both glitches.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KOffice builds and runs both with and without libwps and CMake correctly \
detects whether libwps is present.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindWPG.cmake <span style="color: grey">(cb12f91)</span></li>
<li>filters/artwork/CMakeLists.txt <span style="color: grey">(b949dd9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104191/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic