From koffice-devel Thu Mar 08 19:59:45 2012 From: "Thomas Zander" Date: Thu, 08 Mar 2012 19:59:45 +0000 To: koffice-devel Subject: Re: Review Request: Fix an annoying CMake warning in the msword-odf filter Message-Id: <20120308195945.22435.63965 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=133123684904880 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0156811002124959364==" --===============0156811002124959364== Content-Type: multipart/alternative; boundary="===============5558507812480104594==" --===============5558507812480104594== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104192/#review11246 ----------------------------------------------------------- Ship it! Ship It! - Thomas Zander On March 8, 2012, 12:28 p.m., Robert Mathias Marmorstein wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104192/ > ----------------------------------------------------------- > = > (Updated March 8, 2012, 12:28 p.m.) > = > = > Review request for KOffice. > = > = > Description > ------- > = > CMake 2.8 changed the default behavior of the module finding algorithm so= that it looks in local paths before it looks in system paths. This makes = a lot of sense and there's no reason not to accept the new behavior. Unfor= tunately, CMake generates an annoying warning if you don't add a cmake_poli= cy line to your CMakeLists.txt file approving this change. This patch supp= resses that warning by accepting the new behavior for that filter. > = > = > Diffs > ----- > = > filters/kword/msword-odf/wv2/CMakeLists.txt 2fc0d70 = > = > Diff: http://git.reviewboard.kde.org/r/104192/diff/ > = > = > Testing > ------- > = > Reran cmake and built everything both with gcc and clang. Everything bui= lds fine and both kword and artwork still run just fine. > = > = > Thanks, > = > Robert Mathias Marmorstein > = > --===============5558507812480104594== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104192/

Ship it!

Ship It!
 









- Thomas






On March 8th, 2012, 12:28 p.m., Robert Mathias Marmorstein wrote:









 

  


Review request for KOffice.


By Robert Mathias Marmorstein.




Updated March 8, 2012, 12:28 p.m.








Descripti=
on 

 

 

  
   
CMake 2.8 changed the default behavior of the module finding=
 algorithm so that it looks in local paths before it looks in system paths.=
  This makes a lot of sense and there's no reason not to accept the new=
 behavior.  Unfortunately, CMake generates an annoying warning if you don&#=
39;t add a cmake_policy line to your CMakeLists.txt file approving this cha=
nge.  This patch suppresses that warning by accepting the new behavior for =
that filter.

  		
 






Testing <=
/h1>


 

  
   
Reran cmake and built everything both with gcc and clang.  E=
verything builds fine and both kword and artwork still run just fine.

  		
 








Diffs=
 


    

 
  • filters/kword/msword-odf/wv2/CMakeLists.txt View Diff
--===============5558507812480104594==-- --===============0156811002124959364== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0156811002124959364==--