[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D14436: SwitchDesktop mousewheel options with config dialog added
From: Thomas Otto <noreply () phabricator ! kde ! org>
Date: 2018-07-30 7:06:54
Message-ID: 975d7b6dfd00fd8b1e7030c7712bff04 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
totto marked an inline comment as done.
totto added a comment.
> disabled checkbox for rollover
That was partially meant to overcome the shortcoming that changing the kwin value \
does not change this value until some settings dialog is opened, but with your patch \
this is no longer required.
Plus I wanted to avoid two options for the same thing and add some kind of hint \
where this behavior could be changed. Should I still mention it as plain text (though \
translating that might be complicated) or just leave users to figure it out \
themselves? Again, "go to first config gui of this key" would be nice :)
INLINE COMMENTS
> davidedmundson wrote in desktop.cpp:36
> I have this coming:
> https://phabricator.kde.org/D13034
Great, will keep an eye on that.
> davidedmundson wrote in desktop.h:54
> or just use a regular bool and copy the value in configurationAccepted
>
> Long term, having simpler code tends to be much better than clever code.
Or, even simpler: I'll just drop the duplication between the in-class bool (i.e. the \
the cached value), and the `m_options` config bool and always look it up in \
`m_options`, should be fast enough.
Btw, would a `std::shared_ptr` have been Ok for once? That does not have the bug \
prone non-explicit bool problem and would work as expected.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D14436
To: totto, hein, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">totto marked an inline comment as done.<br />totto added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14436">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>disabled checkbox for rollover</p></blockquote>
<p>That was partially meant to overcome the shortcoming that changing the kwin value \
does not change this value until some settings dialog is opened, but with your patch \
this is no longer required.</p>
<p>Plus I wanted to avoid two options for the same thing and add some kind of hint \
where this behavior could be changed. Should I still mention it as plain text (though \
translating that might be complicated) or just leave users to figure it out \
themselves? Again, "go to first config gui of this key" would be nice \
:)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: \
6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div \
style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; \
padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14436#inline-76279">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">desktop.cpp:36</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">I have this coming: <br /> <a href="https://phabricator.kde.org/D13034" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D13034</a></p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Great, \
will keep an eye on that.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14436#inline-76282">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">davidedmundson</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">desktop.h:54</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">or just use a regular bool and copy the value in configurationAccepted</p>
<p style="padding: 0; margin: 8px;">Long term, having simpler code tends to be much \
better than clever code.</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">Or, even simpler: I'll just drop the \
duplication between the in-class bool (i.e. the the cached value), and the <tt \
style="background: #ebebeb; font-size: 13px;">m_options</tt> config bool and always \
look it up in <tt style="background: #ebebeb; font-size: 13px;">m_options</tt>, \
should be fast enough.</p>
<p style="padding: 0; margin: 8px;">Btw, would a <tt style="background: #ebebeb; \
font-size: 13px;">std::shared_ptr</tt> have been Ok for once? That does not have the \
bug prone non-explicit bool problem and would work as \
expected.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14436">https://phabricator.kde.org/D14436</a></div></div><br \
/><div><strong>To: </strong>totto, hein, broulik, Plasma, davidedmundson<br \
/><strong>Cc: </strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic