[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D14436: SwitchDesktop mousewheel options with config dialog added
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-07-30 10:53:01
Message-ID: 1bcc0b769b8ce1ff4ed64189d25a54c0 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
davidedmundson added inline comments.
INLINE COMMENTS
> desktop.cpp:172
> +namespace {
> +void switchDesktop(bool next, bool rollover, bool invert) {
> const int numDesktops = KWindowSystem::numberOfDesktops();
if you turn this into a method you don't need the rollover/invert args
> totto wrote in desktop.h:54
> Or, even simpler: I'll just drop the duplication between the in-class bool (i.e. \
> the the cached value), and the `m_options` config bool and always look it up in \
> `m_options`, should be fast enough.
> Btw, would a `std::shared_ptr` have been Ok for once? That does not have the bug \
> prone non-explicit bool problem and would work as expected.
> Btw, would a std::shared_ptr have been Ok for once?
TBH, I still would have considered it overkill. It's only two checkboxes, it doesn't \
need any custom design patterns.
If you did want to reduce the few lines of duplication, KConfigXT is the framework to \
look at for doing this sort of thing.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D14436
To: totto, hein, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14436">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14436#inline-76362">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">desktop.cpp:172</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">void</span></span><span class="bright"> </span><span class="n"><span \
class="bright">SwitchDesktop</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">performNextAction</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="bright"></span><span style="color: #aa4000"><span \
class="bright">namespace</span></span><span class="bright"> </span><span \
class="p"><span class="bright">{</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="bright"></span><span style="color: #aa4000"><span \
class="bright">void</span></span><span class="bright"> </span><span class="n"><span \
class="bright">switchDesktop</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> \
</span><span class="n"><span class="bright">next</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #aa4000"><span \
class="bright">bool</span></span><span class="bright"> </span><span class="n"><span \
class="bright">rollover</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> \
</span><span class="n"><span class="bright">invert</span></span><span \
class="bright"></span><span class="p"><span class="bright">)</span></span><span \
class="bright"> </span><span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "> <span style="color: #aa4000">const</span> <span style="color: \
#aa4000">int</span> <span class="n">numDesktops</span> <span style="color: \
#aa2211">=</span> <span class="n">KWindowSystem</span><span style="color: \
#aa2211">::</span><span class="n">numberOfDesktops</span><span class="p">();</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">if you turn this into a method you don't need the rollover/invert \
args</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14436#inline-76324">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">totto</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">desktop.h:54</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Or, even simpler: I'll just drop the duplication between the in-class bool \
(i.e. the the cached value), and the <tt style="background: #ebebeb; font-size: \
13px;">m_options</tt> config bool and always look it up in <tt style="background: \
#ebebeb; font-size: 13px;">m_options</tt>, should be fast enough.</p>
<p style="padding: 0; margin: 8px;">Btw, would a <tt style="background: #ebebeb; \
font-size: 13px;">std::shared_ptr</tt> have been Ok for once? That does not have the \
bug prone non-explicit bool problem and would work as expected.</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">Btw, would a \
std::shared_ptr have been Ok for once?</p></blockquote>
<p style="padding: 0; margin: 8px;">TBH, I still would have considered it overkill. \
It's only two checkboxes, it doesn't need any custom design patterns.</p>
<p style="padding: 0; margin: 8px;">If you did want to reduce the few lines of \
duplication, KConfigXT is the framework to look at for doing this sort of \
thing.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14436">https://phabricator.kde.org/D14436</a></div></div><br \
/><div><strong>To: </strong>totto, hein, broulik, Plasma, davidedmundson<br \
/><strong>Cc: </strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic