[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D14436: SwitchDesktop mousewheel options with config dialog added
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-07-29 20:59:38
Message-ID: f5a0f5b91a3f47633d90944ccd021281 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Showing a disabled checkbox for rollover doesn't make much sense.
IMHO we should either have it as a separate option from kwin and have a checkbox, \
or not have a checkbox at all.
INLINE COMMENTS
> totto wrote in desktop.cpp:36
> The rollover option is from another kde component (kwin), is there a way to get \
> notified whenever this config changes?
I have this coming:
https://phabricator.kde.org/D13034
> desktop.cpp:122
> + QCheckBox *item = new QCheckBox(widget);
> + item->setText(i18nc(e.cfgKey.toStdString().c_str(),
> + e.name.toStdString().c_str()));
Unforunately, that's not how our i18n works.
a script greps for i18n("some text here") to generate the english translations.
> desktop.h:54
>
> + // QSharedPtr has non-explicit operator bool which is bugprone, work \
> around that + struct explicitBool { bool val; };
or just use a regular bool and copy the value in configurationAccepted
Long term, having simpler code tends to be much better than clever code.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D14436
To: totto, hein, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added a comment.<br />This revision now requires changes to proceed. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14436">View Revision</a></tr></table><br \
/><div><div><p>Showing a disabled checkbox for rollover doesn't make much \
sense.<br /> IMHO we should either have it as a separate option from kwin and have a \
checkbox, or not have a checkbox at all.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14436#inline-76083">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">totto</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">desktop.cpp:36</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The rollover \
option is from another kde component (kwin), is there a way to get notified whenever \
this config changes?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">I have this coming: <br /> <a \
href="https://phabricator.kde.org/D13034" class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D13034</a></p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14436#inline-76284">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">desktop.cpp:122</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">QCheckBox</span> <span style="color: #aa2211">*</span><span \
class="n">item</span> <span style="color: #aa2211">=</span> <span style="color: \
#aa4000">new</span> <span class="n">QCheckBox</span><span class="p">(</span><span \
class="n">widget</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">item</span><span style="color: #aa2211">-></span><span \
class="n">setText</span><span class="p">(</span><span class="n">i18nc</span><span \
class="p">(</span><span class="n">e</span><span class="p">.</span><span \
class="n">cfgKey</span><span class="p">.</span><span \
class="n">toStdString</span><span class="p">().</span><span \
class="n">c_str</span><span class="p">(),</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">e</span><span class="p">.</span><span class="n">name</span><span \
class="p">.</span><span class="n">toStdString</span><span class="p">().</span><span \
class="n">c_str</span><span class="p">()));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Unforunately, that's not how our i18n works.</p>
<p style="padding: 0; margin: 8px;">a script greps for i18n("some text \
here") to generate the english translations.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14436#inline-76282">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">desktop.h:54</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #74777d">// QSharedPtr has non-explicit operator bool which is \
bugprone, work around that</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">struct</span> <span class="n">explicitBool</span> <span class="p">{</span> \
<span style="color: #aa4000">bool</span> <span class="n">val</span><span \
class="p">;</span> <span class="p">};</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">or \
just use a regular bool and copy the value in configurationAccepted</p>
<p style="padding: 0; margin: 8px;">Long term, having simpler code tends to be much \
better than clever code.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14436">https://phabricator.kde.org/D14436</a></div></div><br \
/><div><strong>To: </strong>totto, hein, broulik, Plasma, davidedmundson<br \
/><strong>Cc: </strong>davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic