[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14476: QMLScreen: do not declare the engine a member
From:       Frederik Gladhorn <noreply () phabricator ! kde ! org>
Date:       2018-07-30 7:07:23
Message-ID: 82a2bcb670ccf9a34f86cc269bcae321 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  There is no need for this, the only use of the engine is when creating \
QQMLOutputComponent.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14476

AFFECTED FILES
  kcm/src/declarative/qmlscreen.h

To: gladhorn, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">gladhorn created this revision.<br />gladhorn added a \
reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />gladhorn requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14476">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>There is no need for this, the only \
use of the engine is when creating QQMLOutputComponent.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14476">https://phabricator.kde.org/D14476</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kcm/src/declarative/qmlscreen.h</div></div></div><br \
/><div><strong>To: </strong>gladhorn, Plasma<br /><strong>Cc: </strong>plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]