[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14437: Fix QFileDialog not remembering the last visited directory.
From:       Anthony Fieroni <noreply () phabricator ! kde ! org>
Date:       2018-07-30 4:45:59
Message-ID: 1910235ae9378bdc992b4c4694160236 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

anthonyfieroni added inline comments.

INLINE COMMENTS

> apol wrote in kdeplatformfiledialoghelper.cpp:118
> I'm not sure I understand the comment. Is it like a TODO?

It works without comment, i think these connections are not needed.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14437

To: dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson
Cc: apol, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

[Attachment #3 (text/html)]

<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14437">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14437#inline-76304">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">kdeplatformfiledialoghelper.cpp:118</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">I&#039;m not sure I understand the comment. Is it like a TODO?</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It \
works without comment, i think these connections are not \
needed.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14437">https://phabricator.kde.org/D14437</a></div></div><br \
/><div><strong>To: </strong>dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, \
broulik, arichardson<br /><strong>Cc: </strong>apol, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]