[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2630: Support highlighting windows through EffectsHandlerImpl
From:       luebking_(Thomas_Lübking) <noreply () phabricator ! kde ! org>
Date:       2016-08-30 14:50:34
Message-ID: 20160830145031.16501.66904.CEDC3EE6 () phabricator ! kde ! org
[Download RAW message or body]

luebking added inline comments.

INLINE COMMENTS

> effects.cpp:1560
> +    const auto typeId = qMetaTypeId<QVector<KWin::EffectWindow*>>();
> +    for (int i = 0; i < e->metaObject()->methodCount(); ++i) {
> +        auto method = e->metaObject()->method(i);

Errr... wut?
Any reason to not *demand* some sort of soft API (slot signature) instead of digging \
for the next best thing that remotely looks like the right thing?

Maybe provide hard API like "Effect::performFeature(Feature f, QVariant v)"?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2630

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">luebking added inline comments.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2630" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D2630#inline-10332" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">effects.cpp:1560</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">    <span style="color: #aa4000">const</span> <span \
style="color: #aa4000">auto</span> <span class="n">typeId</span> <span style="color: \
#aa2211">=</span> <span class="n">qMetaTypeId</span><span style="color: \
#aa2211">&lt;</span><span class="n">QVector</span><span style="color: \
#aa2211">&lt;</span><span class="n">KWin</span><span style="color: \
#aa2211">::</span><span class="n">EffectWindow</span><span style="color: \
#aa2211">*&gt;&gt;</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">for</span> \
<span class="p">(</span><span style="color: #aa4000">int</span> <span \
class="n">i</span> <span style="color: #aa2211">=</span> <span style="color: \
#601200">0</span><span class="p">;</span> <span class="n">i</span> <span \
style="color: #aa2211">&lt;</span> <span class="n">e</span><span style="color: \
#aa2211">-&gt;</span><span class="n">metaObject</span><span class="p">()</span><span \
style="color: #aa2211">-&gt;</span><span class="n">methodCount</span><span \
class="p">();</span> <span style="color: #aa2211">++</span><span \
class="n">i</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span \
style="color: #aa4000">auto</span> <span class="n">method</span> <span style="color: \
#aa2211">=</span> <span class="n">e</span><span style="color: \
#aa2211">-&gt;</span><span class="n">metaObject</span><span class="p">()</span><span \
style="color: #aa2211">-&gt;</span><span class="n">method</span><span \
class="p">(</span><span class="n">i</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Errr... wut?<br /> Any reason to not *demand* some sort of soft API \
(slot signature) instead of digging for the next best thing that remotely looks like \
the right thing?</p>

<p style="padding: 0; margin: 8px;">Maybe provide hard API like \
&quot;Effect::performFeature(Feature f, QVariant \
v)&quot;?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2630" \
rel="noreferrer">https://phabricator.kde.org/D2630</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland<br /><strong>Cc: \
</strong>luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]