[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D2671: Reduce duplicated code and document very difficult to pa
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-09-06 8:41:27
Message-ID: 20160906084127.6548.87.C5890651 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> Panel.qml:97
> +            //the size a margin should be to force a panel to be the required size \
> above +            readonly property real spacingAtMinSize: Math.max(1, \
> (verticalPanel ? root.width : root.height) - units.iconSizes.smallMedium - \
> units.smallSpacing*2)/2 +

why real? You cannot (should not) have half pixels

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.</td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2671" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D2671#inline-10476" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">Panel.qml:97</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">            <span style="color: #74777d">//the size a margin \
should be to force a panel to be the required size above</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span \
style="color: #004012">readonly</span> <span style="color: #004012">property</span> \
<span style="color: #004012">real</span> <span style="color: \
#aa4000">spacingAtMinSize:</span> <span style="color: #304a96">Math</span><span \
class="p">.</span><span style="color: #004012">max</span><span \
class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span \
class="p">(</span><span style="color: #004012">verticalPanel</span> <span \
style="color: #aa2211">?</span> <span style="color: #aa4000">root.width :</span> \
<span style="color: #004012">root</span><span class="p">.</span><span style="color: \
#004012">height</span><span class="p">)</span> <span style="color: #aa2211">-</span> \
<span style="color: #004012">units</span><span class="p">.</span><span style="color: \
#004012">iconSizes</span><span class="p">.</span><span style="color: \
#004012">smallMedium</span> <span style="color: #aa2211">-</span> <span style="color: \
#004012">units</span><span class="p">.</span><span style="color: \
#004012">smallSpacing</span><span style="color: #aa2211">*</span><span style="color: \
#601200">2</span><span class="p">)</span><span style="color: #aa2211">/</span><span \
style="color: #601200">2</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why \
real? You cannot (should not) have half pixels</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2671" \
rel="noreferrer">https://phabricator.kde.org/D2671</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>broulik, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]