[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D2627: Set the restore geometry after placing a ShellClient for the fi
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-08-30 14:33:49
Message-ID: 20160830143349.16660.38409.3C8BB100 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  In https://phabricator.kde.org/D2627#48943, @luebking wrote:
  
  > Fixwise good, APIwise, maybe add AbstractClient::placeIn(QRect &area) { \
Placement::self()->place(this, area); setGeometryRestore(geometry()); } to  >  a) \
prevent uninformed messing around with the restore geomery  >  b) guarantee sync \
behavior (when placing occurs)  >
  > ?
  
  
  yep makes sense.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2627

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, \
abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">graesslin added a comment.</td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2627" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D2627#48943" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D2627#48943</a>, <a \
href="https://phabricator.kde.org/p/luebking/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@luebking</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Fixwise good, APIwise, maybe add \
AbstractClient::placeIn(QRect &amp;area) { Placement::self()-&gt;place(this, area); \
setGeometryRestore(geometry()); } to<br />  a) prevent uninformed messing around with \
the restore geomery<br />  b) guarantee sync behavior (when placing occurs)</p>

<p>?</p></div>
</blockquote>

<p>yep makes sense.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2627" \
rel="noreferrer">https://phabricator.kde.org/D2627</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland, bshah<br \
/><strong>Cc: </strong>luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]