[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 124 lines] D2631: Correct regression introduced during color kcm rewritting
From:       "ochurlaud (Olivier Churlaud)" <noreply () phabricator ! kde ! org>
Date:       2016-08-30 15:21:23
Message-ID: differential-rev-PHID-DREV-xwa4k2qh5ej4c5c5j3kr-req () phabricator ! kde ! org
[Download RAW message or body]

ochurlaud created this revision.
ochurlaud added reviewers: andreask, Plasma, pino, mart.
ochurlaud added a subscriber: andreask.
ochurlaud set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  @andreask  told me that using the combo box in the color kcm was not doing \
anything. This corrects this.

TEST PLAN
  It compiles, and acts correctly

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2631

AFFECTED FILES
  kcms/colors/scmeditorcolors.cpp
  kcms/colors/scmeditorcolors.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, andreask, #plasma, pino, mart
Cc: andreask, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">ochurlaud created this revision.<br />ochurlaud added \
reviewers: andreask, Plasma, pino, mart.<br />ochurlaud added a subscriber: \
andreask.<br />ochurlaud set the repository for this revision to rPLASMADESKTOP \
Plasma Desktop.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel.</td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2631" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><a \
href="https://phabricator.kde.org/p/andreask/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@andreask</a>  told me that using \
the combo box in the color kcm was not doing anything. This corrects \
this.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>It compiles, and \
acts correctly</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2631" \
rel="noreferrer">https://phabricator.kde.org/D2631</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kcms/colors/scmeditorcolors.cpp<br /> \
kcms/colors/scmeditorcolors.ui</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>ochurlaud, andreask, Plasma, pino, mart<br /><strong>Cc: \
</strong>andreask, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]