--1a9c713d7d5c434cbad3f48a02ffc62f
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

luebking added inline comments.

INLINE COMMENTS

> effects.cpp:1560
> +    const auto typeId = qMetaTypeId<QVector<KWin::EffectWindow*>>();
> +    for (int i = 0; i < e->metaObject()->methodCount(); ++i) {
> +        auto method = e->metaObject()->method(i);

Errr... wut?
Any reason to not *demand* some sort of soft API (slot signature) instead of digging for the next best thing that remotely looks like the right thing?

Maybe provide hard API like "Effect::performFeature(Feature f, QVariant v)"?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2630

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

--1a9c713d7d5c434cbad3f48a02ffc62f
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">luebking=20added=20inline=20comments.</td><a=20=
style=3D"text-decoration:=20none;=20padding:=204px=208px;=20margin:=200=208=
px=208px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20bold;=20bo=
rder-radius:=203px;=20background-color:=20#F7F7F9;=20background-image:=20li=
near-gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-block;=20borde=
r:=201px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabricator.kde.o=
rg/D2630"=20rel=3D"noreferrer">View=20Revision</a></tr></table><br=20/><div=
><strong>INLINE=20COMMENTS</strong><div><div=20style=3D"margin:=206px=200=
=2012px=200;"><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20border-rad=
ius:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F7;=20borde=
r-color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=200=201px=
=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20background:=20#ef=
f2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=3D"float:=
=20right;=20text-decoration:=20none;"=20href=3D"https://phabricator.kde.org=
/D2630#inline-10332"=20rel=3D"noreferrer">View=20Inline</a><span=20style=3D=
"color:=20#4b4d51;=20font-weight:=20bold;">effects.cpp:1560</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#d0ffd0;">=20=20=20=20<span=20=
style=3D"color:=20#aa4000">const</span>=20<span=20style=3D"color:=20#aa4000=
">auto</span>=20<span=20class=3D"n">typeId</span>=20<span=20style=3D"color:=
=20#aa2211">=3D</span>=20<span=20class=3D"n">qMetaTypeId</span><span=20styl=
e=3D"color:=20#aa2211">&lt;</span><span=20class=3D"n">QVector</span><span=
=20style=3D"color:=20#aa2211">&lt;</span><span=20class=3D"n">KWin</span><sp=
an=20style=3D"color:=20#aa2211">::</span><span=20class=3D"n">EffectWindow</=
span><span=20style=3D"color:=20#aa2211">*&gt;&gt;</span><span=20class=3D"p"=
>();</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20style=3D"color:=20#aa4000">for</span>=20<=
span=20class=3D"p">(</span><span=20style=3D"color:=20#aa4000">int</span>=20=
<span=20class=3D"n">i</span>=20<span=20style=3D"color:=20#aa2211">=3D</span=
>=20<span=20style=3D"color:=20#601200">0</span><span=20class=3D"p">;</span>=
=20<span=20class=3D"n">i</span>=20<span=20style=3D"color:=20#aa2211">&lt;</=
span>=20<span=20class=3D"n">e</span><span=20style=3D"color:=20#aa2211">-&gt=
;</span><span=20class=3D"n">metaObject</span><span=20class=3D"p">()</span><=
span=20style=3D"color:=20#aa2211">-&gt;</span><span=20class=3D"n">methodCou=
nt</span><span=20class=3D"p">();</span>=20<span=20style=3D"color:=20#aa2211=
">++</span><span=20class=3D"n">i</span><span=20class=3D"p">)</span>=20<span=
=20class=3D"p">{</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20<span=20style=3D"color:=20#aa4000">au=
to</span>=20<span=20class=3D"n">method</span>=20<span=20style=3D"color:=20#=
aa2211">=3D</span>=20<span=20class=3D"n">e</span><span=20style=3D"color:=20=
#aa2211">-&gt;</span><span=20class=3D"n">metaObject</span><span=20class=3D"=
p">()</span><span=20style=3D"color:=20#aa2211">-&gt;</span><span=20class=3D=
"n">method</span><span=20class=3D"p">(</span><span=20class=3D"n">i</span><s=
pan=20class=3D"p">);</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">Errr...=20wut?<br=20/>
Any=20reason=20to=20not=20*demand*=20some=20sort=20of=20soft=20API=20(slot=
=20signature)=20instead=20of=20digging=20for=20the=20next=20best=20thing=20=
that=20remotely=20looks=20like=20the=20right=20thing?</p>

<p=20style=3D"padding:=200;=20margin:=208px;">Maybe=20provide=20hard=20API=
=20like=20&quot;Effect::performFeature(Feature=20f,=20QVariant=20v)&quot;?<=
/p></div></div></div></div></div><br=20/><div><strong>REPOSITORY</strong><d=
iv><div>rKWIN=20KWin</div></div></div><br=20/><div><strong>REVISION=20DETAI=
L</strong><div><a=20href=3D"https://phabricator.kde.org/D2630"=20rel=3D"nor=
eferrer">https://phabricator.kde.org/D2630</a></div></div><br=20/><div><str=
ong>EMAIL=20PREFERENCES</strong><div><a=20href=3D"https://phabricator.kde.o=
rg/settings/panel/emailpreferences/"=20rel=3D"noreferrer">https://phabricat=
or.kde.org/settings/panel/emailpreferences/</a></div></div><br=20/><div><st=
rong>To:=20</strong>graesslin,=20KWin,=20Plasma=20on=20Wayland<br=20/><stro=
ng>Cc:=20</strong>luebking,=20plasma-devel,=20kwin,=20lesliezhai,=20ali-moh=
amed,=20hardening,=20jensreuterberg,=20abetts,=20sebas<br=20/></div>
--1a9c713d7d5c434cbad3f48a02ffc62f--