[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2014-12-12 11:38:20
Message-ID: CAPLgePrii4Hgs0rxC_vrkpCayiVeXVs6qugXiSPxnZxHVRLZSw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Fri, Oct 3, 2014 at 1:16 PM, Alex Merry <alex.merry@kde.org> wrote:
>
> On 2014-09-17 10:47, Martin Gräßlin wrote:
>
>> Hi all,
>>
>> I just prepared moving kglobalacceld from plasma-workspace into
>> kglobalaccel.
>> You can find the code in my personal clone of kglobalaccel at [1] in
>> branch
>> master.
>>
>> The following steps were performed so far:
>> * filter-branch on plasma-workspace to just have all kglobalacceld commits
>> * move all files to src/runtime
>> * merge code in kglobalaccel
>> * adjust CMakeLists to find additionally needed dependencies for runtime
>> part
>> * raise tier to 3 in metadata
>>
>> Please have a look at it, whether I have forgotten something or should do
>> something differently.
>>
>
> Git history looks sensible.
>
> Things I'm unsure about is:
>> * how does the raise of framework needs to be reflected in cmake
>>
>
> It doesn't.
>
> * how do one expose the different licences?
>>
>
> A License section in README.md?
>
> * is it needed to export the new dependencies? After all they are just
>> runtime
>> deps?
>>
>
> No, because they are not needed at compile-time by software that uses
> KGlobalAccel.
>
> Do we want an option to disable compilation of the runtime? Is the runtime
> needed on all platforms? I seem to remember some discussion suggesting it
> either wasn't or needn't be, but I can't remember the details.
>
> Alex
>
Quoting from IRC just now: "<jleclanche> we'd like to use it [kglobalaccel]
in lxqt, but the framework is useless without its client atm"
Martin - what's the status of this? Is any help needed? Can we get this
into Frameworks 5.6?
Cheers
--
Martin Klapetek | KDE Developer
[Attachment #5 (text/html)]
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Oct 3, 2014 \
at 1:16 PM, Alex Merry <span dir="ltr"><<a href="mailto:alex.merry@kde.org" \
target="_blank">alex.merry@kde.org</a>></span> wrote:<blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span \
class="">On 2014-09-17 10:47, Martin Gräßlin wrote:<br> <blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hi all,<br>
<br>
I just prepared moving kglobalacceld from plasma-workspace into kglobalaccel.<br>
You can find the code in my personal clone of kglobalaccel at [1] in branch<br>
master.<br>
<br>
The following steps were performed so far:<br>
* filter-branch on plasma-workspace to just have all kglobalacceld commits<br>
* move all files to src/runtime<br>
* merge code in kglobalaccel<br>
* adjust CMakeLists to find additionally needed dependencies for runtime part<br>
* raise tier to 3 in metadata<br>
<br>
Please have a look at it, whether I have forgotten something or should do<br>
something differently.<br>
</blockquote>
<br></span>
Git history looks sensible.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Things I'm unsure about is:<br>
* how does the raise of framework needs to be reflected in cmake<br>
</blockquote>
<br></span>
It doesn't.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* how do one expose the different licences?<br>
</blockquote>
<br></span>
A License section in README.md?<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* is it needed to export the new dependencies? After all they are just runtime<br>
deps?<br>
</blockquote>
<br></span>
No, because they are not needed at compile-time by software that uses \
KGlobalAccel.<br> <br>
Do we want an option to disable compilation of the runtime? Is the runtime needed on \
all platforms? I seem to remember some discussion suggesting it either wasn't or \
needn't be, but I can't remember the details.<br> <br>
Alex<br></blockquote><div><br></div><div>Quoting from IRC just now: \
"<jleclanche> we'd like to use it [kglobalaccel] in lxqt, but the \
framework is useless without its client atm"<br></div><div><br></div><div>Martin \
- what's the status of this? Is any help needed? Can we get this into Frameworks \
5.6?<br></div><div><br></div></div><div>Cheers</div>-- <br><div \
class="gmail_signature"><div><span style="color:rgb(102,102,102)">Martin Klapetek | \
KDE Developer</span></div></div> </div></div>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic