[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon
From: "Gregor Mi" <codestruct () posteo ! org>
Date: 2014-12-12 11:22:52
Message-ID: 20141212112252.4026.73795 () probe ! kde ! org
[Download RAW message or body]
--===============2713908831150564528==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 12, 2014, 11:18 a.m., Hugo Pereira Da Costa wrote:
> > Seriously ! this is abusing review board. Silent consent ?
> > At the very least one should deprecate the part of the API that allow apps to set \
> > the icon, since it is not honoured. I would honestly recommand to revert this \
> > commit.
>
> Hugo Pereira Da Costa wrote:
> mmm ok. I take it back (sorry, over reacted without actually reading the diff)
> This is about kpagewidget not setting the icon to ktitlewidget rather than making \
> ktitlewidget not display the set icon) please ignore (sorry again)
>
> For what its worth, I'm not so happy with the change still (I liked the icon). But \
> thats only a matter of taste and without rational.
Thanks for clarifying. :-)
- Gregor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121379/#review71849
-----------------------------------------------------------
On Dec. 12, 2014, 11:04 a.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121379/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 11:04 a.m.)
>
>
> Review request for KDE Frameworks, Christoph Feck and Dominik Haumann.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> As mentioned in [KPageView/KTitleWidget: Remove top right \
> icon](https://forum.kde.org/viewtopic.php?f=285&t=123837) the top-right icon serves \
> no visible purpose and can even be a distraction. This patch removes the code that \
> adds the icon.
>
> Diffs
> -----
>
> src/kpageview.cpp 69d1bf9a20549b74557f3fdf9a7057cb74258cb1
>
> Diff: https://git.reviewboard.kde.org/r/121379/diff/
>
>
> Testing
> -------
>
> Screenshots:
> http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_1before.png (before patch)
> http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_2after.png (after)
> http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_1before.png (before patch)
> http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_2after.png (after)
>
>
> Thanks,
>
> Gregor Mi
>
>
--===============2713908831150564528==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121379/">https://git.reviewboard.kde.org/r/121379/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 12th, 2014, 11:18 a.m. UTC, <b>Hugo \
Pereira Da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; \
word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Seriously ! this is abusing review \
board. Silent consent ? At the very least one should deprecate the part of the API \
that allow apps to set the icon, since it is not honoured. I would honestly recommand \
to revert this commit.</p></pre> </blockquote>
<p>On December 12th, 2014, 11:20 a.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">mmm \
ok. I take it back (sorry, over reacted without actually reading the diff) This is \
about kpagewidget not setting the icon to ktitlewidget rather than making \
ktitlewidget not display the set icon) please ignore (sorry again)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For what its worth, I'm not so happy with the change \
still (I liked the icon). But thats only a matter of taste and without \
rational.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for clarifying. :-)</p></pre> <br />
<p>- Gregor</p>
<br />
<p>On December 12th, 2014, 11:04 a.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Christoph Feck and Dominik Haumann.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2014, 11:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As mentioned in <a \
href="https://forum.kde.org/viewtopic.php?f=285&t=123837" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">KPageView/KTitleWidget: Remove top right icon</a> the top-right icon serves \
no visible purpose and can even be a distraction. This patch removes the code that \
adds the icon.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Screenshots: \
http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-<em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">1before.png (before patch) \
http://wstaw.org/m/2014/12/07/kcmshell5_devinfo</em>-<em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">2after.png (after) http://wstaw.org/m/2014/12/07/kcmshell5_mouse</em>-<em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">1before.png (before patch) \
http://wstaw.org/m/2014/12/07/kcmshell5_mouse</em>-_2after.png (after)</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kpageview.cpp <span style="color: \
grey">(69d1bf9a20549b74557f3fdf9a7057cb74258cb1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121379/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2713908831150564528==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic