From kde-frameworks-devel Fri Dec 12 11:38:20 2014 From: Martin Klapetek Date: Fri, 12 Dec 2014 11:38:20 +0000 To: kde-frameworks-devel Subject: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework Message-Id: X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=141838434216763 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1260041574399779682==" --===============1260041574399779682== Content-Type: multipart/alternative; boundary=001a11c266d62c35ef050a03564c --001a11c266d62c35ef050a03564c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Oct 3, 2014 at 1:16 PM, Alex Merry wrote: > > On 2014-09-17 10:47, Martin Gr=C3=A4=C3=9Flin wrote: > >> Hi all, >> >> I just prepared moving kglobalacceld from plasma-workspace into >> kglobalaccel. >> You can find the code in my personal clone of kglobalaccel at [1] in >> branch >> master. >> >> The following steps were performed so far: >> * filter-branch on plasma-workspace to just have all kglobalacceld commi= ts >> * move all files to src/runtime >> * merge code in kglobalaccel >> * adjust CMakeLists to find additionally needed dependencies for runtime >> part >> * raise tier to 3 in metadata >> >> Please have a look at it, whether I have forgotten something or should d= o >> something differently. >> > > Git history looks sensible. > > Things I'm unsure about is: >> * how does the raise of framework needs to be reflected in cmake >> > > It doesn't. > > * how do one expose the different licences? >> > > A License section in README.md? > > * is it needed to export the new dependencies? After all they are just >> runtime >> deps? >> > > No, because they are not needed at compile-time by software that uses > KGlobalAccel. > > Do we want an option to disable compilation of the runtime? Is the runtim= e > needed on all platforms? I seem to remember some discussion suggesting it > either wasn't or needn't be, but I can't remember the details. > > Alex > Quoting from IRC just now: " we'd like to use it [kglobalaccel] in lxqt, but the framework is useless without its client atm" Martin - what's the status of this? Is any help needed? Can we get this into Frameworks 5.6? Cheers --=20 Martin Klapetek | KDE Developer --001a11c266d62c35ef050a03564c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On F= ri, Oct 3, 2014 at 1:16 PM, Alex Merry <alex.merry@kde.org>= wrote:
On 2014-09-17 10:47, Martin Gr=C3= =A4=C3=9Flin wrote:
Hi all,

I just prepared moving kglobalacceld from plasma-workspace into kglobalacce= l.
You can find the code in my personal clone of kglobalaccel at [1] in branch=
master.

The following steps were performed so far:
* filter-branch on plasma-workspace to just have all kglobalacceld commits<= br> * move all files to src/runtime
* merge code in kglobalaccel
* adjust CMakeLists to find additionally needed dependencies for runtime pa= rt
* raise tier to 3 in metadata

Please have a look at it, whether I have forgotten something or should do something differently.

 Git history looks sensible.

Things I'm unsure about is:
* how does the raise of framework needs to be reflected in cmake

 It doesn't.

* how do one expose the different licences?

 A License section in README.md?

* is it needed to export the new dependencies? After all they are just runt= ime
deps?

 No, because they are not needed at compile-time by software that uses KGlob= alAccel.

Do we want an option to disable compilation of the runtime? Is the runtime = needed on all platforms? I seem to remember some discussion suggesting it e= ither wasn't or needn't be, but I can't remember the details.
Alex

Quoting from IRC just now: "&= lt;jleclanche> we'd like to use it [kglobalaccel] in lxqt, but the f= ramework is useless without its client atm"

Martin - what's the status of this? Is any help needed? Can we get t= his into Frameworks 5.6?

Cheers
-- =
Martin Klapetek | KDE=C2=A0Developer
--001a11c266d62c35ef050a03564c-- --===============1260041574399779682== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============1260041574399779682==--