'Review Request: fix dbus service registration & invocation'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: fix dbus service registration & invocation
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-29 23:28:24
Message-ID: 20121229232824.27606.37688 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108016/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

Problem is two-folded.

1. w/o the explicit unregistration in the deconstructor, kwin fails to register the \
service every other time on --replace (it's still taken by the running instance) 2. \
the usage of the lowercase org.kde.kwin instead of org.kde.KWin - only the latter is \
explicitly registered anyway and will be implcitily registered only when there's no \
running instance occupying it

I was tempted to claim the lowercase variant but actually the upper/CamelCase variant \
is the present *regular* one, despite that even KWin code used the wrong one. So i \
fixed the invocation (in the compositor kcm ... and some of my aliases / scripts ;-) \
instead.

Next to the explicit unregitration i also added a fail check and watchdog, but with \
the explicit unregistration that actually never hit here, so it might be worth it to \
use that failsafe to get the lowercase variant as well (requires maintainer choice =)

Diffs
-----

  kwin/dbusinterface.h d8e8cd3 
  kwin/dbusinterface.cpp 0aa6eb0 
  kwin/kcmkwin/kwincompositing/main.cpp 84a2895 

Diff: http://git.reviewboard.kde.org/r/108016/diff/

Testing
-------

some qwarning's, tested my "countdown" alias and also the compositing kcm is free of \
"opengl broken" and "loading effects failed" junk!

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108016/">http://git.reviewboard.kde.org/r/108016/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Problem is two-folded.

1. w/o the explicit unregistration in the deconstructor, kwin fails to register the \
service every other time on --replace (it&#39;s still taken by the running instance) \
2. the usage of the lowercase org.kde.kwin instead of org.kde.KWin - only the latter \
is explicitly registered anyway and will be implcitily registered only when \
there&#39;s no running instance occupying it

I was tempted to claim the lowercase variant but actually the upper/CamelCase variant \
is the present *regular* one, despite that even KWin code used the wrong one. So i \
fixed the invocation (in the compositor kcm ... and some of my aliases / scripts ;-) \
instead.

Next to the explicit unregitration i also added a fail check and watchdog, but with \
the explicit unregistration that actually never hit here, so it might be worth it to \
use that failsafe to get the lowercase variant as well (requires maintainer choice \
=)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">some qwarning&#39;s, tested my &quot;countdown&quot; alias and also the \
compositing kcm is free of &quot;opengl broken&quot; and &quot;loading effects \
failed&quot; junk!</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/dbusinterface.h <span style="color: grey">(d8e8cd3)</span></li>

 <li>kwin/dbusinterface.cpp <span style="color: grey">(0aa6eb0)</span></li>

 <li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(84a2895)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108016/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 