This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108016/

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Description

Problem is two-folded.

1. w/o the explicit unregistration in the deconstructor, kwin fails to register the service every other time on --replace (it's still taken by the running instance)
2. the usage of the lowercase org.kde.kwin instead of org.kde.KWin - only the latter is explicitly registered anyway and will be implcitily registered only when there's no running instance occupying it

I was tempted to claim the lowercase variant but actually the upper/CamelCase variant is the present *regular* one, despite that even KWin code used the wrong one. So i fixed the invocation (in the compositor kcm ... and some of my aliases / scripts ;-) instead.

Next to the explicit unregitration i also added a fail check and watchdog, but with the explicit unregistration that actually never hit here, so it might be worth it to use that failsafe to get the lowercase variant as well (requires maintainer choice =)

Testing

some qwarning's, tested my "countdown" alias and also the compositing kcm is free of "opengl broken" and "loading effects failed" junk!

Diffs

  • kwin/dbusinterface.h (d8e8cd3)
  • kwin/dbusinterface.cpp (0aa6eb0)
  • kwin/kcmkwin/kwincompositing/main.cpp (84a2895)

View Diff