From kwin Sat Dec 29 23:28:24 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sat, 29 Dec 2012 23:28:24 +0000 To: kwin Subject: Review Request: fix dbus service registration & invocation Message-Id: <20121229232824.27606.37688 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135682371314964 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0907884845172869955==" --===============0907884845172869955== Content-Type: multipart/alternative; boundary="===============3191342074782693938==" --===============3191342074782693938== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108016/ ----------------------------------------------------------- Review request for kwin and Martin Gr=C3=A4=C3=9Flin. Description ------- Problem is two-folded. 1. w/o the explicit unregistration in the deconstructor, kwin fails to regi= ster the service every other time on --replace (it's still taken by the run= ning instance) 2. the usage of the lowercase org.kde.kwin instead of org.kde.KWin - only t= he latter is explicitly registered anyway and will be implcitily registered= only when there's no running instance occupying it I was tempted to claim the lowercase variant but actually the upper/CamelCa= se variant is the present *regular* one, despite that even KWin code used t= he wrong one. So i fixed the invocation (in the compositor kcm ... and some= of my aliases / scripts ;-) instead. Next to the explicit unregitration i also added a fail check and watchdog, = but with the explicit unregistration that actually never hit here, so it mi= ght be worth it to use that failsafe to get the lowercase variant as well (= requires maintainer choice =3D) Diffs ----- kwin/dbusinterface.h d8e8cd3 = kwin/dbusinterface.cpp 0aa6eb0 = kwin/kcmkwin/kwincompositing/main.cpp 84a2895 = Diff: http://git.reviewboard.kde.org/r/108016/diff/ Testing ------- some qwarning's, tested my "countdown" alias and also the compositing kcm i= s free of "opengl broken" and "loading effects failed" junk! Thanks, Thomas L=C3=BCbking --===============3191342074782693938== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/108016/

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Descripti= on 

Problem is two-folded.

1. w/o the explicit unregistration in the deconstructor, kwin fails to regi=
ster the service every other time on --replace (it's still taken by the=
 running instance)
2. the usage of the lowercase org.kde.kwin instead of org.kde.KWin - only t=
he latter is explicitly registered anyway and will be implcitily registered=
 only when there's no running instance occupying it

I was tempted to claim the lowercase variant but actually the upper/CamelCa=
se variant is the present *regular* one, despite that even KWin code used t=
he wrong one. So i fixed the invocation (in the compositor kcm ... and some=
 of my aliases / scripts ;-) instead.

Next to the explicit unregitration i also added a fail check and watchdog, =
but with the explicit unregistration that actually never hit here, so it mi=
ght be worth it to use that failsafe to get the lowercase variant as well (=
requires maintainer choice =3D)

Testing <= /h1> 
some qwarning's, tested my "countdown" alias a=
nd also the compositing kcm is free of "opengl broken" and "=
loading effects failed" junk!

Diffs=

  • kwin/dbusinterface.h (d8e8cd3)
  • kwin/dbusinterface.cpp (0aa6eb0)
  • kwin/kcmkwin/kwincompositing/main.cpp (84a= 2895)

View Diff
--===============3191342074782693938==-- --===============0907884845172869955== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0907884845172869955==--