[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: fix dbus service registration & invocation
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-12-30 8:17:11
Message-ID: 20121230081711.14796.25279 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108016/#review24219
-----------------------------------------------------------
Ship it!
nice one. Apart from the nitpick I'm looking forward to not have these warnings in \
the KCM anymore :-)
kwin/dbusinterface.cpp
<http://git.reviewboard.kde.org/r/108016/#comment18559>
as I just looked at KRazy issues the other day: it will complain here that you \
have to first include your own header.
Best move it below the complete include section and add a // Qt
- Martin Gräßlin
On Dec. 29, 2012, 11:28 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108016/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2012, 11:28 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Description
> -------
>
> Problem is two-folded.
>
> 1. w/o the explicit unregistration in the deconstructor, kwin fails to register the \
> service every other time on --replace (it's still taken by the running instance) 2. \
> the usage of the lowercase org.kde.kwin instead of org.kde.KWin - only the latter \
> is explicitly registered anyway and will be implcitily registered only when there's \
> no running instance occupying it
> I was tempted to claim the lowercase variant but actually the upper/CamelCase \
> variant is the present *regular* one, despite that even KWin code used the wrong \
> one. So i fixed the invocation (in the compositor kcm ... and some of my aliases / \
> scripts ;-) instead.
> Next to the explicit unregitration i also added a fail check and watchdog, but with \
> the explicit unregistration that actually never hit here, so it might be worth it \
> to use that failsafe to get the lowercase variant as well (requires maintainer \
> choice =)
>
> Diffs
> -----
>
> kwin/dbusinterface.h d8e8cd3
> kwin/dbusinterface.cpp 0aa6eb0
> kwin/kcmkwin/kwincompositing/main.cpp 84a2895
>
> Diff: http://git.reviewboard.kde.org/r/108016/diff/
>
>
> Testing
> -------
>
> some qwarning's, tested my "countdown" alias and also the compositing kcm is free \
> of "opengl broken" and "loading effects failed" junk!
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108016/">http://git.reviewboard.kde.org/r/108016/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nice one. Apart from the \
nitpick I'm looking forward to not have these warnings in the KCM anymore \
:-)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108016/diff/1/?file=102897#file102897line22" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/dbusinterface.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GNU \
General Public License for more details.</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">22</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <QDBusServiceWatcher></span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">22</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
"dbusinterface.h"</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">23</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
"dbusinterface.h"</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as I just \
looked at KRazy issues the other day: it will complain here that you have to first \
include your own header.
Best move it below the complete include section and add a // Qt</pre>
</div>
<br />
<p>- Martin</p>
<br />
<p>On December 29th, 2012, 11:28 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2012, 11:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Problem is two-folded.
1. w/o the explicit unregistration in the deconstructor, kwin fails to register the \
service every other time on --replace (it's still taken by the running instance) \
2. the usage of the lowercase org.kde.kwin instead of org.kde.KWin - only the latter \
is explicitly registered anyway and will be implcitily registered only when \
there's no running instance occupying it
I was tempted to claim the lowercase variant but actually the upper/CamelCase variant \
is the present *regular* one, despite that even KWin code used the wrong one. So i \
fixed the invocation (in the compositor kcm ... and some of my aliases / scripts ;-) \
instead.
Next to the explicit unregitration i also added a fail check and watchdog, but with \
the explicit unregistration that actually never hit here, so it might be worth it to \
use that failsafe to get the lowercase variant as well (requires maintainer choice \
=)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">some qwarning's, tested my "countdown" alias and also the \
compositing kcm is free of "opengl broken" and "loading effects \
failed" junk!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/dbusinterface.h <span style="color: grey">(d8e8cd3)</span></li>
<li>kwin/dbusinterface.cpp <span style="color: grey">(0aa6eb0)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(84a2895)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108016/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic