[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Extended Border support in Aurorae
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-29 16:23:36
Message-ID: 20121229162336.2885.47991 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107936/#review24190
-----------------------------------------------------------
Ship it!
Aside the less technical questions below, it looks fine.
kwin/clients/aurorae/src/aurorae.cpp
<http://git.reviewboard.kde.org/r/107936/#comment18540>
coding style? ;-P
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/107936/#comment18538>
too specific? (does Aurorae support vertical titlebars in this context?)
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/107936/#comment18539>
me and iirc also hugo only use them to cover the "no border" case, not as \
addition to a present border
does Aurorae support zero borders or would this be an opportunity to introduce \
them?
- Thomas Lübking
On Dec. 27, 2012, 7:59 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107936/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2012, 7:59 a.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Extended Border support in Aurorae
>
> Aurorae Themes can make use of the extended borders feature to allow
> resizing outside the window decoration area. So far only Plastik makes
> use of it in the Tiny border case.
>
> This should be extended in future by adding generic NoSideBorders and
> NoBorders sizes as used by Oxygen.
>
> FEATURE: 308992
> FIXED-IN: 4.11
>
>
> This addresses bug 308992.
> http://bugs.kde.org/show_bug.cgi?id=308992
>
>
> Diffs
> -----
>
> kwin/clients/aurorae/src/aurorae.h 6e187eaeb9973692aebba8883d4c3783606a1336
> kwin/clients/aurorae/src/aurorae.cpp b6c219b72fca87fa4adefa3e1a590a81bf0d1f5f
> kwin/clients/aurorae/src/qml/Decoration.qml \
> b885278be7a8ec3874ce7ca5bfa8ba500a65f025 \
> kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml \
> d18d7a78e736a15197b4a1bc8c9e6126b5e3264f
> Diff: http://git.reviewboard.kde.org/r/107936/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107936/">http://git.reviewboard.kde.org/r/107936/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aside the less technical \
questions below, it looks fine.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107936/diff/1/?file=101664#file101664line604" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/clients/aurorae/src/aurorae.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">QRegion AuroraeClient::region(KDecorationDefines::Region r)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">604</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">rect</span><span class="p">.</span><span class="n">translate</span><span \
class="p">(</span><span class="o">-</span> <span class="n">paddingLeft</span><span \
class="p">,</span> <span class="o">-</span> <span class="n">paddingTop</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">coding \
style? ;-P</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107936/diff/1/?file=101666#file101666line23" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">23</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
root.extendedBorderTop = 0;</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">too \
specific? (does Aurorae support vertical titlebars in this context?)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107936/diff/1/?file=101666#file101666line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
enableExtendedBorders();</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">me and iirc \
also hugo only use them to cover the "no border" case, not as addition to a \
present border
does Aurorae support zero borders or would this be an opportunity to introduce \
them?</pre> </div>
<br />
<p>- Thomas</p>
<br />
<p>On December 27th, 2012, 7:59 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2012, 7:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Extended Border support in Aurorae
Aurorae Themes can make use of the extended borders feature to allow
resizing outside the window decoration area. So far only Plastik makes
use of it in the Tiny border case.
This should be extended in future by adding generic NoSideBorders and
NoBorders sizes as used by Oxygen.
FEATURE: 308992
FIXED-IN: 4.11</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=308992">308992</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/clients/aurorae/src/aurorae.h <span style="color: \
grey">(6e187eaeb9973692aebba8883d4c3783606a1336)</span></li>
<li>kwin/clients/aurorae/src/aurorae.cpp <span style="color: \
grey">(b6c219b72fca87fa4adefa3e1a590a81bf0d1f5f)</span></li>
<li>kwin/clients/aurorae/src/qml/Decoration.qml <span style="color: \
grey">(b885278be7a8ec3874ce7ca5bfa8ba500a65f025)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml <span \
style="color: grey">(d18d7a78e736a15197b4a1bc8c9e6126b5e3264f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107936/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic