'Review Request: disconnect all client signals when it's closed'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: disconnect all client signals when it's closed
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-12-29 16:16:04
Message-ID: 20121229161604.2378.2700 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108008/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

the client can still live on and emit stuff, but the compositing has been fininshed \
for it, so the effect window handed to effects connecting the signal is NULL

This addresses bug 310142.
    http://bugs.kde.org/show_bug.cgi?id=310142

Diffs
-----

  kwin/effects.cpp 7025883 

Diff: http://git.reviewboard.kde.org/r/108008/diff/

Testing
-------

running it atm. i don't think it can cause major regressions (nor spotted anything)
deleted is sent via Workspace -> EffectsHandler -> receivers, so not affected.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108008/">http://git.reviewboard.kde.org/r/108008/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the client can still live on and emit stuff, but the compositing has \
been fininshed for it, so the effect window handed to effects connecting the signal \
is NULL</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">running it atm. i don&#39;t think it can cause major regressions (nor \
spotted anything) deleted is sent via Workspace -&gt; EffectsHandler -&gt; receivers, \
so not affected.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=310142">310142</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects.cpp <span style="color: grey">(7025883)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108008/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 