From kwin Sat Dec 29 16:23:36 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Sat, 29 Dec 2012 16:23:36 +0000 To: kwin Subject: Re: Review Request: Extended Border support in Aurorae Message-Id: <20121229162336.2885.47991 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=135679822708260 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3805871617377130503==" --===============3805871617377130503== Content-Type: multipart/alternative; boundary="===============9196053440928148223==" --===============9196053440928148223== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107936/#review24190 ----------------------------------------------------------- Ship it! Aside the less technical questions below, it looks fine. kwin/clients/aurorae/src/aurorae.cpp coding style? ;-P kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml too specific? (does Aurorae support vertical titlebars in this context?) kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml me and iirc also hugo only use them to cover the "no border" case, not = as addition to a present border = does Aurorae support zero borders or would this be an opportunity to in= troduce them? - Thomas L=C3=BCbking On Dec. 27, 2012, 7:59 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107936/ > ----------------------------------------------------------- > = > (Updated Dec. 27, 2012, 7:59 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > Extended Border support in Aurorae > = > Aurorae Themes can make use of the extended borders feature to allow > resizing outside the window decoration area. So far only Plastik makes > use of it in the Tiny border case. > = > This should be extended in future by adding generic NoSideBorders and > NoBorders sizes as used by Oxygen. > = > FEATURE: 308992 > FIXED-IN: 4.11 > = > = > This addresses bug 308992. > http://bugs.kde.org/show_bug.cgi?id=3D308992 > = > = > Diffs > ----- > = > kwin/clients/aurorae/src/aurorae.h 6e187eaeb9973692aebba8883d4c3783606a= 1336 = > kwin/clients/aurorae/src/aurorae.cpp b6c219b72fca87fa4adefa3e1a590a81bf= 0d1f5f = > kwin/clients/aurorae/src/qml/Decoration.qml b885278be7a8ec3874ce7ca5bfa= 8ba500a65f025 = > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml d18d7a= 78e736a15197b4a1bc8c9e6126b5e3264f = > = > Diff: http://git.reviewboard.kde.org/r/107936/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============9196053440928148223== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107936/

Ship it!

Aside the =
less technical questions below, it looks fine.

= =
kwin/clients/aurorae/src/aurorae.cpp (Diff revision 1) 

   
QRegion AuroraeClient::region(KDecorationDefines::Region r)


  

 

  

    
    

    604
    
    rect.translate(=
- paddingLeft, - paddingTop);

  


 





coding style? ;-P

















 =

 =




 

 
  

   
    kwin/clients/aurorae/themes/plastik/package/contents/ui/mai=
n.qml
    

     (Diff revision 1)

    
   
  

 

 
  


   


  

 

  

    
    

    23
    
        root.extendedBorderTop =3D 0;

  


 





too specific? (does Aurorae support vertical titlebars in this conte=
xt?)

















 =

 =




 

 
  

   
    kwin/clients/aurorae/themes/plastik/package/contents/ui/mai=
n.qml
    

     (Diff revision 1)

    
   
  

 

 
  


   


  

 

  

    
    

    38
    
            enableExtendedBorders();

  


 





me and iirc also hugo only use them to cover the "no border&quo=
t; case, not as addition to a present border

does Aurorae support zero borders or would this be an opportunity to introd=
uce them?









- Thomas






On December 27th, 2012, 7:59 a.m., Martin Gr=C3=A4=C3=9Flin wrote:









 

  


Review request for kwin.


By Martin Gr=C3=A4=C3=9Flin.




Updated Dec. 27, 2012, 7:59 a.m.








Descripti=
on 

 

 

  
   
Extended Border support in Aurorae

Aurorae Themes can make use of the extended borders feature to allow
resizing outside the window decoration area. So far only Plastik makes
use of it in the Tiny border case.

This should be extended in future by adding generic NoSideBorders and
NoBorders sizes as used by Oxygen.

FEATURE: 308992
FIXED-IN: 4.11

  		
 









 Bugs: 


 308992







Diffs=
 


    

 
  • kwin/clients/aurorae/src/aurorae.h (6e187e=
aeb9973692aebba8883d4c3783606a1336)
    • 

 
  • kwin/clients/aurorae/src/aurorae.cpp (b6c2=
19b72fca87fa4adefa3e1a590a81bf0d1f5f)
    • 

 
  • kwin/clients/aurorae/src/qml/Decoration.qml (d18d7a78e736a15197b4a1bc8c9e6126b5e3264f)





View Diff





  		
 











  

 



--===============9196053440928148223==--

--===============3805871617377130503==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============3805871617377130503==--